Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add supported connectionModes and updated supportedMessageTypes to destination definitions #801

Merged
merged 31 commits into from
Dec 1, 2023

Conversation

ujjwal-ab
Copy link
Contributor

@ujjwal-ab ujjwal-ab commented Aug 1, 2023

Description of the change

Resolves INT-753
Resolves INT-131

  • Update attributes supportedConnectionModes and supportedMessageTypes to destinations where it is missing.

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f0aea5) 100.00% compared to head (9df31f5) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #801   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           78        78           
  Branches        13        13           
=========================================
  Hits            78        78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

Copy link

linear bot commented Nov 29, 2023

krishna2020
krishna2020 previously approved these changes Nov 30, 2023
Copy link

linear bot commented Nov 30, 2023

INT-131 Review the configuration attributes required in configuration files

Integration specific information goes to public facing docs manually whenever a change is made. To make this automatic & have up-to-date information in docs, few automation tasks via hugo framework are planned which can pull in data from config-backend API’s & push to the docs.

Here’s the related PRD: Project overview

As part of this story, first two requirements have to be fulfilled.

  1. Destination quick info table
  2. Properties mapping tables

Research Spec

Properties/Informations Required for Destinations quick info table:

  • Supported Source Types - Already present as supportedSourceTypes array in db-config. eg. -

  • Supported Connection Modes - Currently present in destination on new UI as supportedConnectionModes , needs to be added in remaining destinations.

  • Supported Message Types - Supported Message Types are already present in most of the destinations as supportedMessageTypes, needs to be added in remaining destinations.

  • Supported Message Types for device mode - Supported message types for device mode, this can contain the message types supported in device mode for the particular destination. This can be added in all the destinations db-config supporting device mode. eg.

    "supportedMessageTypes": {
    			"cloud": ["track", "group"],
    			"device":{
    					"web": ["track", "group"],
    					"android": ["track", "group"]
    				}
        }
    
    
    
  • Supported Message Types for hybrid mode - In some hybrid mode supported destinations it is present as

    "hybridModeCloudEventsFilter": {
          "web": {
            "messageType": ["track", "group"]
          }
        },
    
    

Properties/Informations Required for Property mapping table:

  • All the property mappings should be present at a specific path. eg. src/v0/destinations/<destinationName>/data

Points of discussion -

  • Some of the property mappings for the destinations lies in the transform.js or util.js files. eg. -
  • For CDK, there are no specific mapping files.
  • How the mappings should be fetched for js-sdk.

Copy link
Contributor

@sanpj2292 sanpj2292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ujjwal-ab ujjwal-ab merged commit 09f13fe into develop Dec 1, 2023
5 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the configurations-update branch March 1, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants