Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include sendPageNameInSDK in includeKeys array #809

Merged
merged 7 commits into from
Aug 3, 2023
Merged

fix: include sendPageNameInSDK in includeKeys array #809

merged 7 commits into from
Aug 3, 2023

Conversation

anantjain45823
Copy link
Contributor

Description of the change

Including sendPageNameInSDK in includeKeys array

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@anantjain45823 anantjain45823 self-assigned this Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

The author of this PR, anantjain45823, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at support@codecov.io with any questions.

@anantjain45823 anantjain45823 merged commit a7b3159 into develop Aug 3, 2023
5 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the enhancement/customerIoPage branch November 3, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihir-4116 mihir-4116 mihir-4116 approved these changes

@ItsSudip ItsSudip ItsSudip approved these changes

@lvrach lvrach Awaiting requested review from lvrach lvrach is a code owner

@cisse21 cisse21 Awaiting requested review from cisse21 cisse21 is a code owner

@nidhilashkari17 nidhilashkari17 Awaiting requested review from nidhilashkari17

@debanjan97 debanjan97 Awaiting requested review from debanjan97 debanjan97 is a code owner

@ssbeefeater ssbeefeater Awaiting requested review from ssbeefeater ssbeefeater is a code owner

@AchuthaSourabhC AchuthaSourabhC Awaiting requested review from AchuthaSourabhC

@ruchiramoitra ruchiramoitra Awaiting requested review from ruchiramoitra ruchiramoitra is a code owner

@ashishRudder ashishRudder Awaiting requested review from ashishRudder

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507 shrouti1507 is a code owner

@sandeepdsvs sandeepdsvs Awaiting requested review from sandeepdsvs sandeepdsvs is a code owner

@krishna2020 krishna2020 Awaiting requested review from krishna2020 krishna2020 is a code owner

@desusai7 desusai7 Awaiting requested review from desusai7

@1abhishekpandey 1abhishekpandey Awaiting requested review from 1abhishekpandey 1abhishekpandey is a code owner

@bardisg bardisg Awaiting requested review from bardisg

Assignees

@anantjain45823 anantjain45823

Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anantjain45823 @ItsSudip @mihir-4116