Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase keen's write key size constraint to 250 #814

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

yashasvibajpai
Copy link
Contributor

Description of the change

Keen's write key is more than the current set size constraint of 100 characters. We are fixing it here

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (51b77b7) 100.00% compared to head (a1ba8e1) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #814   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           78        78           
  Branches        13        13           
=========================================
  Hits            78        78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krishna2020 krishna2020 changed the base branch from develop to release/v1.44.0 August 8, 2023 06:27
@yashasvibajpai yashasvibajpai merged commit 6f6984e into release/v1.44.0 Aug 8, 2023
6 checks passed
@yashasvibajpai yashasvibajpai deleted the fix.keen.writekey.size.constraint branch August 8, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants