Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new fields for authnetication purpose #866

Closed
wants to merge 5 commits into from

Conversation

ujjwal-ab
Copy link
Contributor

Description of the change

Resolves INT-135

  • Add new fields functionEnvironment, credentials and requireAuthentication
  • Remove triggerType, gcloudAuthorization, apiKeyId

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@linear
Copy link

linear bot commented Aug 28, 2023

INT-135 Move GoogleCloudFunction to streaming destination & support batching

Currently, GCF authorisation has time limit of max 12hrs and is not in ready-to-use state. By moving it as streaming destination, authorisation can be done at role level.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (43641ce) 100.00% compared to head (e75b95e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #866   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           78        78           
  Branches        13        13           
=========================================
  Hits            78        78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

krishna2020
krishna2020 previously approved these changes Sep 13, 2023
@ujjwal-ab ujjwal-ab changed the base branch from develop to hotfix/sep.23 September 25, 2023 12:53
@ujjwal-ab ujjwal-ab changed the base branch from hotfix/sep.23 to develop September 25, 2023 12:55
@ujjwal-ab ujjwal-ab dismissed krishna2020’s stale review September 25, 2023 12:55

The base branch was changed.

@ujjwal-ab
Copy link
Contributor Author

Closing this. Alternate PR for this.

@ujjwal-ab ujjwal-ab closed this Sep 26, 2023
@devops-github-rudderstack devops-github-rudderstack deleted the feat/google-cloud-function branch December 22, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants