Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(INT-649): move intercom to new ui #907

Closed
wants to merge 8 commits into from

Conversation

mihir-4116
Copy link
Contributor

Description of the change

  • Move intercom destination to new UI format

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@linear
Copy link

linear bot commented Sep 15, 2023

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3cbdd9c) 0.00% compared to head (3567fec) 100.00%.

Additional details and impacted files
@@              Coverage Diff               @@
##           develop      #907        +/-   ##
==============================================
+ Coverage         0   100.00%   +100.00%     
==============================================
  Files            0         2         +2     
  Lines            0        78        +78     
  Branches         0        13        +13     
==============================================
+ Hits             0        78        +78     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"sendAnonymousId",
"mobileApiKeyIOS",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need mobileApiKeyAndroid and mobileApiKeyIOS in cloud mode?

Also updateLastRequestAt is removed is it not needed anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's not needed anymore in new version

{
"type": "textInput",
"label": "Access Token",
"configKey": "apiKey",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label and config key are different names why is that ? Cant we just call this accessToken?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was developed like that but will update it and will add it in migration as well

Comment on lines +263 to +266
"sdkTemplate": {
"title": "Web SDK settings",
"note": "not visible in the ui",
"fields": []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's required even if no fields are needed for device mode, need to handle it from front-end

@utsabc
Copy link
Member

utsabc commented Sep 26, 2023

Please add UI screen shot

@mihir-4116
Copy link
Contributor Author

image image

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants