-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(INT-649): move intercom to new ui #907
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #907 +/- ##
==============================================
+ Coverage 0 100.00% +100.00%
==============================================
Files 0 2 +2
Lines 0 78 +78
Branches 0 13 +13
==============================================
+ Hits 0 78 +78 ☔ View full report in Codecov by Sentry. |
"sendAnonymousId", | ||
"mobileApiKeyIOS", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need mobileApiKeyAndroid
and mobileApiKeyIOS
in cloud mode?
Also updateLastRequestAt
is removed is it not needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's not needed anymore in new version
{ | ||
"type": "textInput", | ||
"label": "Access Token", | ||
"configKey": "apiKey", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Label and config key are different names why is that ? Cant we just call this accessToken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was developed like that but will update it and will add it in migration as well
"sdkTemplate": { | ||
"title": "Web SDK settings", | ||
"note": "not visible in the ui", | ||
"fields": [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's required even if no fields are needed for device mode, need to handle it from front-end
Please add UI screen shot |
This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
Description of the change
Checklists
Development
Code review