Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(INT-649): move intercom to new ui #907

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions src/configurations/destinations/intercom/db-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
"blacklistedEvents",
"whitelistedEvents",
"oneTrustCookieCategories",
"eventFilteringOption",
"updateLastRequestAt"
"eventFilteringOption"
],
"excludeKeys": [],
"supportedSourceTypes": [
Expand All @@ -32,21 +31,36 @@
"shopify"
],
"supportedMessageTypes": ["identify", "track", "group"],
"supportedConnectionModes": {
"web": [
"cloud",
"device"
],
"android": [
"cloud",
"device"
],
"ios": [
"cloud",
"device"
]
},
"destConfig": {
"defaultConfig": [
"apiKey",
"appId",
"collectContext",
"apiServer",
"sendAnonymousId",
"mobileApiKeyIOS",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need mobileApiKeyAndroid and mobileApiKeyIOS in cloud mode?

Also updateLastRequestAt is removed is it not needed anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's not needed anymore in new version

"blacklistedEvents",
"whitelistedEvents",
"mobileApiKeyAndroid",
"eventFilteringOption",
"oneTrustCookieCategories",
"updateLastRequestAt"
"oneTrustCookieCategories"
],
"android": ["useNativeSDK", "mobileApiKeyAndroid"],
"ios": ["useNativeSDK", "mobileApiKeyIOS"],
"web": ["useNativeSDK"]
"android": ["useNativeSDK", "mobileApiKeyAndroid", "connectionMode"],
"ios": ["useNativeSDK", "mobileApiKeyIOS", "connectionMode"],
"web": ["useNativeSDK","appId", "connectionMode"]
},
"secretKeys": []
}
Expand Down
105 changes: 104 additions & 1 deletion src/configurations/destinations/intercom/schema.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,106 @@
{
"configSchema": null
"configSchema": {
"$schema": "http://json-schema.org/draft-07/schema#",
"required": ["apiKey", "apiServer"],
"type": "object",
"properties": {
"apiKey": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{1,100})$"
},
"apiServer": {
"type": "string",
"enum": ["standard", "eu", "au"],
"default": "standard"
},
"appId": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
},
"mobileApiKeyAndroid": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
},
"mobileApiKeyIOS": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
},
"sendAnonymousId": {
"type": "boolean",
"default": false
},
"eventFilteringOption": {
"type": "string",
"enum": ["disable", "whitelistedEvents", "blacklistedEvents"],
"default": "disable"
},
"whitelistedEvents": {
"type": "array",
"items": {
"type": "object",
"properties": {
"eventName": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
}
}
}
},
"blacklistedEvents": {
"type": "array",
"items": {
"type": "object",
"properties": {
"eventName": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
}
}
}
},
"oneTrustCookieCategories": {
"type": "array",
"items": {
"type": "object",
"properties": {
"oneTrustCookieCategory": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
}
}
}
},
"useNativeSDK": {
"type": "object",
"properties": {
"android": {
"type": "boolean"
},
"ios": {
"type": "boolean"
},
"web": {
"type": "boolean"
}
}
},
"connectionMode": {
"type": "object",
"properties": {
"android": {
"type": "string",
"enum": ["cloud", "device"]
},
"ios": {
"type": "string",
"enum": ["cloud", "device"]
},
"web": {
"type": "string",
"enum": ["cloud", "device"]
}
}
}
}
}
}
Loading