-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: indentation for objects #101
Conversation
WalkthroughThe recent changes introduce a new constant for indentation ( Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Coverage report
Test suite run success187 tests passing in 4 suites. Report generated by 🧪jest coverage report action from 2431bcc |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 14 14
Lines 4565 4685 +120
Branches 1082 1100 +18
==========================================
+ Hits 4565 4685 +120 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- src/constants.ts (1 hunks)
- src/reverse_translator.ts (3 hunks)
Files skipped from review due to trivial changes (1)
- src/constants.ts
Additional comments not posted (4)
src/reverse_translator.ts (4)
36-36
: The import statement correctly includes the newINDENTATION_SPACES
constant. Ensure that this constant is used consistently throughout the file.
218-219
: The modification to include aprefix
parameter intranslateExpressions
is correctly implemented. This allows dynamic indentation based on the translation context, which aligns with the PR's objectives to fix object indentation issues.
432-434
: ThegetIndentation
method is correctly implemented. It uses theINDENTATION_SPACES
constant to generate a string of spaces based on the current indentation level. This method will help maintain consistent indentation across different parts of the translated output.
438-442
: The changes totranslateObjectExpression
are well-implemented. The method now correctly adjusts the indentation level and applies it before and after translating the object properties. This ensures that the output is properly formatted, which is critical for readability and maintenance.
What are the changes introduced in this PR?
Fix indentation for objects while reverse translating
What is the related Linear task?
Resolves INT-2240
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.
Summary by CodeRabbit