Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(INT-833): conditional expression parsing is failing parse objects #46

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

koladilip
Copy link
Collaborator

Description of the change

With this fix, conditional expression now accepts both objects and block of statements.

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 3415/3415
🟢 Branches 100% 911/911
🟢 Functions 100% 265/265
🟢 Lines 100% 3415/3415

Test suite run success

109 tests passing in 2 suites.

Report generated by 🧪jest coverage report action from 0c67953

@koladilip koladilip changed the title fix: conditional expression parsing is failing parse objects fix(INT-833): conditional expression parsing is failing parse objects Oct 11, 2023
@koladilip koladilip merged commit bf27bae into main Oct 18, 2023
7 checks passed
@koladilip koladilip deleted the fix.conditional-expression branch October 18, 2023 05:06
@github-actions github-actions bot mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants