Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor api type declarations #150

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

MoumitaM
Copy link

@MoumitaM MoumitaM commented Sep 6, 2024

Description of the change

Refactor api type declarations

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.70%. Comparing base (1415ae5) to head (514e568).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #150   +/-   ##
========================================
  Coverage    50.70%   50.70%           
========================================
  Files            3        3           
  Lines          355      355           
  Branches        80       80           
========================================
  Hits           180      180           
  Misses         115      115           
  Partials        60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

index.d.ts Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 6, 2024

@MoumitaM MoumitaM merged commit befe175 into develop Sep 6, 2024
8 of 9 checks passed
@MoumitaM MoumitaM deleted the feature/sdk-2268-node-serverside-sdk-code-review branch September 6, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants