Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Fix inner hits source filtering test #1947

Open
wants to merge 1 commit into
base: 6.x
Choose a base branch
from
Open

[6.x] Fix inner hits source filtering test #1947

wants to merge 1 commit into from

Conversation

deguif
Copy link
Collaborator

@deguif deguif commented Mar 23, 2021

No description provided.

@deguif
Copy link
Collaborator Author

deguif commented Mar 23, 2021 •
edited
Loading

This PR goal was to test the new 6.8.1 version of elasticsearch/elasticsearch published yesterday by @ezimuel .
It seems it's still breaking on class Elasticsearch\Endpoints\Indices\ForceMerge which is not found anymore.

PS: It seems it's now Elasticsearch\Endpoints\Indices\Forcemerge with lowercased m 🤔

@deguif deguif mentioned this pull request Mar 23, 2021
Merged
@deguif deguif self-assigned this Mar 23, 2021
@deguif
Copy link
Collaborator Author

deguif commented Mar 24, 2021

@ezimuel Don't know what to do on my side. This class renaming from Elasticsearch\Endpoints\Indices\ForceMerge to Elasticsearch\Endpoints\Indices\Forcemerge seems a bug on 6.8.1.

Recent version 7.12.0 has no issue as it uses the Elasticsearch\Endpoints\Indices\ForceMerge class naming.

@reedy
Copy link
Contributor

reedy commented Mar 25, 2021

Looks like ForceMerge was renamed in elastic/elasticsearch-php@2da5f93#diff-c4834c4ebd492607a0af1ab55c7575c6a84323f8be87ca6f7f8833cf4ffc2675

Screenshot 2021-03-25 at 14 47 28

@kbond kbond mentioned this pull request Apr 23, 2021
Closed
@ezimuel
Copy link
Collaborator

ezimuel commented May 14, 2021

@deguif just commented here elastic/elasticsearch-php#1131 (comment)

@ezimuel
Copy link
Collaborator

ezimuel commented Jul 14, 2021

Just released elasticsearch-php 6.8.2 including the fix for this issue (elastic/elasticsearch-php#1151).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@deguif deguif

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deguif @reedy @ezimuel