Allow escaped meta-characters in version script patterns

rui314 · Dec 24, 2023 · 9554b92 · 9554b92
1 parent 669ada0
commit 9554b92
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/common/glob.cc b/common/glob.cc
@@ -79,6 +79,14 @@ std::optional<Glob> Glob::compile(std::string_view pat) {
     case '*':
       vec.push_back({STAR});
       break;
+    case '\\':
+      if (pat.empty())
+        return {};
+      if (vec.empty() || vec.back().kind != STRING)
+        vec.push_back({STRING});
+      vec.back().str += pat[0];
+      pat = pat.substr(1);
+      break;
     default:
       if (vec.empty() || vec.back().kind != STRING)
         vec.push_back({STRING});

diff --git a/test/elf/version-script23.sh b/test/elf/version-script23.sh
@@ -0,0 +1,15 @@
+#!/bin/bash
+. $(dirname $0)/common.inc
+
+cat <<'EOF' > $t/a.ver
+VER1 { foo\?; };
+EOF
+
+cat <<EOF | $CC -c -o $t/b.o -xassembler -
+.globl "foo?"
+"foo?":
+EOF
+
+$CC -B. -shared -Wl,--version-script=$t/a.ver -o $t/c.so $t/b.o
+readelf -W --dyn-syms $t/c.so > $t/log
+grep -Fq 'foo?@@VER1' $t/log