Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin property mapping w fixed tests #33

Merged
merged 14 commits into from
Aug 19, 2024

Conversation

Jesus-Osuna-M
Copy link

@Jesus-Osuna-M Jesus-Osuna-M commented Aug 13, 2024

Original PR: #31

Enhancements:

  • PropertyResolver added so that properties set on the project/framework level are retrieved
  • A new property can be set on project/framework level to force plugin to use proxy-settings set on the JVM
  • Failing unit tests were fixed
  • Small refactor to make code more legible

The new property needs to be set on project (or framework):

project.plugin.WorkflowStep.edu.ohio.ais.rundeck.HttpWorkflowStepPlugin.useSystemProxySettings=true
project.plugin.WorkflowNodeStep.edu.ohio.ais.rundeck.HttpWorkflowNodeStepPlugin.useSystemProxySettings=true

This tells the plugin to use the JVM proxy settings as set here

@Jesus-Osuna-M Jesus-Osuna-M marked this pull request as ready for review August 14, 2024 15:42
Copy link

@ronaveva ronaveva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add unit tests for the new methods

Copy link

@ronaveva ronaveva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets make sure this gets into the bug bash

@Jesus-Osuna-M Jesus-Osuna-M merged commit dcd109b into master Aug 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants