Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Create SpectralClanMgmt plugin" #6371

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

rebelego
Copy link
Contributor

@rebelego rebelego commented Jul 29, 2024

Reverts #6157

@runelite-github-app
Copy link

runelite-github-app bot commented Jul 29, 2024

@Nightfirecat
Copy link
Member

Oh, I hadn't realized that was a plugin addition instead of a plugin change. Can you change this to instead be an added line reading:

disabled=awaiting further changes

@rebelego
Copy link
Contributor Author

Oh, I hadn't realized that was a plugin addition instead of a plugin change. Can you change this to instead be an added line reading:

disabled=awaiting further changes

I'm not sure where to put that line.

@iProdigy
Copy link
Member

Instead of deleting plugins/spectralclanmgmt, add that line to the end of the file

@rebelego
Copy link
Contributor Author

disabled=awaiting further changes

Gotcha. I added the line to the file and updated the commit hash.

@iProdigy
Copy link
Member

For this PR, please only add the disabled line. Once that is merged you can open a new PR for the commit hash update (so we can properly review the code changes)

by the way, you made that change in a separate branch from this PR

@rebelego
Copy link
Contributor Author

For this PR, please only add the disabled line. Once that is merged you can open a new PR for the commit hash update (so we can properly review the code changes)

by the way, you made that change in a separate branch from this PR

Whoops, I'm an idiot. I'll try adding just the line on the right branch this time.

@rebelego
Copy link
Contributor Author

Did I do it right this time?

@Nightfirecat Nightfirecat merged commit 1788923 into runelite:master Jul 29, 2024
2 of 3 checks passed
@rebelego rebelego deleted the revert-6157-spectralclanmgmt branch July 29, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants