Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New plugin 'gauntlet-chest-value' #7193

Closed
wants to merge 4 commits into from

Conversation

RealityWinner
Copy link

This plugin displays the total value of the loot you receive from the gauntlet chest. Tested and verified in-game.

@runelite-github-app
Copy link

runelite-github-app bot commented Dec 31, 2024

@YvesW
Copy link
Member

YvesW commented Dec 31, 2024

Isn't this something that might be worthwhile to PR to core? I'd at least discuss it in #development

@RealityWinner
Copy link
Author

RealityWinner commented Dec 31, 2024

Isn't this something that might be worthwhile to PR to core? I'd at least discuss it in #development

There already is a "Lunar Chest Value" for Moons of Peril which is part of why I went this route but most definitely I can do that. I'm not in the runelite discord but i'll hop in and see. Perhaps both could be incorporated.

@YvesW
Copy link
Member

YvesW commented Jan 1, 2025

Yeah, that one should also just be added to core IMO instead of adding a hub plugin for every chest. Alternatively if Adam wouldn't want that, we could make 1 chest value hub plugin.

@RealityWinner
Copy link
Author

That's certainly a possibility, i'm gonna have to leave that in your realm on the decision. I most definitely can assist if that's the decided route. The Lunar Chest plugin does a little extra than normal is the only concern, in that it additionally calculates the amount of prayer xp you'd get from the material received.

@tylerwgrass
Copy link
Member

Seems there isn't (currently) opposition to adding this to the core loot tracker, so I'll move this to waiting for now.
This is a likely reference

If something changes this PR can be given another look.

@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label Jan 2, 2025
@RealityWinner
Copy link
Author

So no to this plugin, yes to adding it to the core loot tracker plugin? Okay. Is someone going to do that or am I supposed to and submit a PR to core?

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jan 2, 2025
@tylerwgrass
Copy link
Member

You are welcome to open a PR to core yourself

@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin added waiting for author waiting for the pr author to make changes or respond to questions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants