-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New plugin 'gauntlet-chest-value' #7193
Conversation
New plugin |
Isn't this something that might be worthwhile to PR to core? I'd at least discuss it in #development |
There already is a "Lunar Chest Value" for Moons of Peril which is part of why I went this route but most definitely I can do that. I'm not in the runelite discord but i'll hop in and see. Perhaps both could be incorporated. |
Yeah, that one should also just be added to core IMO instead of adding a hub plugin for every chest. Alternatively if Adam wouldn't want that, we could make 1 chest value hub plugin. |
That's certainly a possibility, i'm gonna have to leave that in your realm on the decision. I most definitely can assist if that's the decided route. The Lunar Chest plugin does a little extra than normal is the only concern, in that it additionally calculates the amount of prayer xp you'd get from the material received. |
Seems there isn't (currently) opposition to adding this to the core loot tracker, so I'll move this to waiting for now. If something changes this PR can be given another look. |
So no to this plugin, yes to adding it to the core loot tracker plugin? Okay. Is someone going to do that or am I supposed to and submit a PR to core? |
You are welcome to open a PR to core yourself |
This plugin displays the total value of the loot you receive from the gauntlet chest. Tested and verified in-game.