Fix Bosses without Time #7213
Merged
Fix Bosses without Time #7213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was still trying to send Boss kill messages for bosses without PBs. This is only used for bosses with PB so cleaned this up and removed it accordingly. Incremented version to 3.2.2
|
The previous version was unknowingly broken (Before this pull request) so if someone can look at it quickly it would be greatly appreciated. Right now its causing our users to get rate limited in discord due to the plugin is sending bad requests to discord cause its hitting the boss time part of the plugin for bosses that don't contain boss times |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was still trying to send Boss kill messages for bosses without PBs. This is only used for bosses with PB so cleaned this up and removed it accordingly.
Also Fixed Combat Achievements not properly sending a screenshot when achieved. Also added in additional logging when webhooks fail
Incremented version to 3.2.2