Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update impling-saver to 2.0.0 #7261

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheLope
Copy link
Contributor

@TheLope TheLope commented Jan 22, 2025

Complete refactor of the plugin to provide functionality of saving implings only when the associated clue is found in the bank
This is because the prior functionality was only checking the players inventory, which was since added to the core game.
Large portions of the functionality mirror what was done for the Casket Saver refactor.

@runelite-github-app
Copy link

runelite-github-app bot commented Jan 22, 2025

@tylerwgrass
Copy link
Member

Given that this was transferred to you from another author, you should at least properly attribute them credit in the copyright

@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label Jan 22, 2025
@TheLope
Copy link
Contributor Author

TheLope commented Jan 22, 2025

Given that this was transferred to you from another author, you should at least properly attribute them credit in the copyright

Okay yeah totally happy to do so just wasn't sure the proper formatting, expected feedback on that one

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants