Un-nest proof hint events for arguments of functions/hooks #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robertorosmaninho
approved these changes
Aug 29, 2024
|
@Robertorosmaninho I added a commit with the update and a simplification to the parser logic. Thanks for pointing that out! |
Wow! That was a huge simplification! Thanks! |
gtrepta
requested changes
Aug 30, 2024
gtrepta
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The events that correspond to evaluation of arguments of functions and hooks are currently nested inside the corresponding function/hook event. There is no need for that and it creates various complications in the processing of the proof hint trace. For this reason, this PR un-nests those events so that they appear before their corresponding function/hook event.