Add pattern matching support for list random access patterns #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwightguth
force-pushed
the
list-set
branch
from
3487ca0
to
90a42f4
Compare
Robertorosmaninho
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
I couldn’t spot anything obvious that would prevent me from approving this PR, but I’m not very familiar with this code either. I’ll let @theo25 give the final approval on that.
I would like to see, if not some tests, at least some instructions on how we could execute it ourselves. It may be a helpful starting point for us in the future if we want to fully support it in K.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not rigorously tested, nor is it likely to be in the near future because the code it was written to support ended up not being worth merging. However, it is broadly useful code that may find value in the future, so I would like to get it merged.
It also includes a few fixes to python scripts in the repo that had gone slightly stale.