Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playwright error handling and increased login timeout (5min) #241

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Playwright error handling and increased login timeout (5min) #241

merged 4 commits into from
Oct 18, 2023

Conversation

rusq
Copy link
Owner

@rusq rusq commented Oct 18, 2023

  • handle nil request value
  • increase the default login page timeout to 5 min
  • remove unneded check
  • -browser-timeout parameter

Fixes #240

@rusq rusq mentioned this pull request Oct 18, 2023
Closed
@rusq rusq merged commit cf51095 into master Oct 18, 2023
3 checks passed
@rusq rusq deleted the okta branch October 18, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crashes on Linux and Windows
1 participant
@rusq