Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Killing with SIGTERM exits with 1 instead of 0 #76

Open
grazzolini opened this issue Jun 18, 2024 · 2 comments
Open

Killing with SIGTERM exits with 1 instead of 0 #76

grazzolini opened this issue Jun 18, 2024 · 2 comments

Comments

@grazzolini
Copy link

I have scripted using wl-screenrec on sway and, given that I'm not starting it from a terminal directly, I want to be able to just send SIGTERM to wl-screenrec for it to stop recording. With this change: ad0dd42#diff-42cb6807ad74b3e201c5a7ca98b911c5fa08380e942be6e4ac5807f8377f87fcR1747, it made it to exit with return value 1 on SIGTERM.

@hholst80
Copy link
Contributor

It is reasonable to terminate with 1 if there was an error gracefully terminating the recording. I use the same workflow but I use kill -INT instead of the default TERM ;-)

@grazzolini
Copy link
Author

Unless the recording failed for some reason, I don't think the program should exit with 1, even if terminated with SIGTERM. I'll try using SIGINT as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants