feat: Add to_vcf_string method for bcf::Record #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctsa
changed the title
ctsa
changed the title
Added return value checking on vcf_format, which also suggests that the methods should return a Result and shound't be implemented directly as a Display trait.
ctsa
changed the title
johanneskoester
approved these changes
Nov 12, 2024
Pull Request Test Coverage Report for Build 11799729563Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case (PacificBiosciences/HiFiCNV#31) where some element of an input vcf/bcf record is surprising, and the program needs to error out. To make the error message as informative as possible for this case we'd like to print the problematic vcf record in the error message.
I'm proposing to add a new
to_vcf_stringmethod tobcf::Recordas a solution to this issue.