Skip to content

Commit

Permalink
Merge #16: Do not enable std in feature matrix loop
Browse files Browse the repository at this point in the history
995f606 Do not enable std in feature matrix loop (Tobin C. Harding)

Pull request description:

  We have a bug that is giving false positives in CI because the `std` feature is always enabled when doing feature matrix loop.

  Found while hacking on a new `psbt` crate.

ACKs for top commit:
  apoelstra:
    utACK 995f606

Tree-SHA512: 7502e51d3856c8fd60ed123fa4101d1a9e2624bdb120be1f0630578f1b350286e6219d464c37b31d8948caaa9d99cc5e53a11efdde59b7b1e7378aaebb7373bf
  • Loading branch information
apoelstra committed Sep 19, 2024
2 parents f92b276 + 995f606 commit 906ffd4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions ci/run_task.sh
Original file line number Diff line number Diff line change
Expand Up @@ -201,14 +201,14 @@ loop_features() {
if (( len > 1 )); then
for ((i = 0 ; i < len ; i++ ));
do
$cargo build --features="$use ${array[i]}"
$cargo test --features="$use ${array[i]}"
$cargo build --no-default-features --features="$use ${array[i]}"
$cargo test --no-default-features --features="$use ${array[i]}"

if (( i < len - 1 )); then
for ((j = i + 1 ; j < len ; j++ ));
do
$cargo build --features="$use ${array[i]} ${array[j]}"
$cargo test --features="$use ${array[i]} ${array[j]}"
$cargo build --no-default-features --features="$use ${array[i]} ${array[j]}"
$cargo test --no-default-features --features="$use ${array[i]} ${array[j]}"
done
fi
done
Expand Down

0 comments on commit 906ffd4

Please sign in to comment.