Skip to content

Commit

Permalink
Fix the fuzz bug
Browse files Browse the repository at this point in the history
We have a bug in the `run_task` script where by in processing the `fuzz`
crate we _break_ instead of continuing. This means any crate listed
after `fuzz` in the `CRATES` env var will be skipped. However we don't
want to bother with the `test_vars.sh` script in `fuzz`, so continue to
handle the `fuzz` crate inline in `build_and_test` but call `continue`.

While we are at it call `cargo test` for good measure.
  • Loading branch information
tcharding committed Aug 10, 2024
1 parent 3494cee commit a14c1d2
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions ci/run_task.sh
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,16 @@ build_and_test() {
for crate in "${CRATES[@]}"; do
local test_vars_script="$REPO_DIR/$crate/contrib/test_vars.sh"

# Building the fuzz crate is more-or-less just a sanity check.
# Building/testing the fuzz crate is more-or-less just a sanity check.
#
# Do it here instead of calling down to `do_test` so we don't have to
# worry about `contrib/test_vars.sh` in the `fuzz` crates.
if [ "$crate" = "fuzz" ]; then
pushd "$REPO_DIR/$crate" > /dev/null
cargo --locked build
cargo --locked test
popd > /dev/null
break
continue
fi

verbose_say "Sourcing $test_vars_script"
Expand Down

0 comments on commit a14c1d2

Please sign in to comment.