Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bitcoin #311

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Oct 15, 2023

Upgrade rust-bitcoin dependency to the newly release v0.31.0. This is needed so we can update bitcoind and then rust-miniscript to use the new bitcoin release.

@tcharding
Copy link
Member Author

tcharding commented Oct 27, 2023

Do you want me to push the first 2 patches up as a separate PR for merge consideration @stevenroose? (I'm hesitant to bring your attention to patch 3 :) EDIT: Comment is stale now.

lateminer added a commit to CoinBlack/rust-blackcoinmore-rpc that referenced this pull request Oct 27, 2023
@tcharding tcharding force-pushed the 10-16-upgrade-bitcoin branch from 96300ce to 71d0af8 Compare October 30, 2023 04:37
@tcharding tcharding force-pushed the 10-16-upgrade-bitcoin branch from 71d0af8 to 43f09f1 Compare November 1, 2023 13:44
@tcharding tcharding marked this pull request as ready for review November 1, 2023 13:48
@tcharding tcharding force-pushed the 10-16-upgrade-bitcoin branch from 43f09f1 to e378008 Compare November 3, 2023 22:12
Upgrade to the recent bitcoin v0.31.0 release by doing:

- Remove dependency on `bitcoin_private`, use hex stuff from
`bitcoin::hex` (re-export of `hex-conservative`).
- Do type renames.
- Add a couple of type annotations when parsing `Address`.
@tcharding tcharding force-pushed the 10-16-upgrade-bitcoin branch from e378008 to bae9bd2 Compare November 12, 2023 22:17
@stevenroose stevenroose merged commit bae9bd2 into rust-bitcoin:master Nov 15, 2023
10 checks passed
@tcharding tcharding deleted the 10-16-upgrade-bitcoin branch April 8, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants