Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to bitcoin 0.31.0 and make a new release #622

Closed
benma opened this issue Nov 1, 2023 · 8 comments · Fixed by #629
Closed

update to bitcoin 0.31.0 and make a new release #622

benma opened this issue Nov 1, 2023 · 8 comments · Fixed by #629

Comments

@benma
Copy link
Contributor

benma commented Nov 1, 2023

Would be nice to keep all the rust-* crates in sync with each other in terms of releases so that downstream projects can make use of the newest releases.

@tcharding
Copy link
Member

Thanks for raising the issue and for noticing we did a new release! This upgrade is held up by the bitcoind-tests crate needing to update bitcoind and bitcoincore-rpc.

All of which are my fault because early during the RC cycle I just deleted bitcoind-tests locally and promptly forgot about it.

@tcharding
Copy link
Member

Oh perhaps we can just use old versions of bitcoind and bitcoincore-rcp in bitcoind-tests temporarily, @sanket1729 and/or @apoelstra would you be ok with that? (Just an idea, I haven't checked it works yet.) And do an RC of miniscript that folk can get on and use?

@apoelstra
Copy link
Member

@tcharding I'm fine with it, but it's likely not to work because bitcoind and bitcoincore-rpc depend on an old version of bitcoin.

But maybe you can hack around any incompatibilities by e.g. serializing objects of one version and deserializing as objects of another.

@tcharding
Copy link
Member

I think we [0] should just take this as a painful lesson and in future we should have the rust-bitcoincore-rcp release ready to drop the same time as rust-bitcoin.

[0] (mainly me, because I deleted bitcoind-tests/ out of rust-miniscript a few weeks ago while testing RCs)

@apoelstra
Copy link
Member

There was a very long time when the rust-bitcoincore-rpc maintainer was absent (which is why there are a ton of PRs where I was doing review even though I don't use or maintain the crate). If we gate rust-bitcoin releases on it we'll regret it.

Though in this case, yeah, we probably could've done it.

In the past we've hacked around this. I don't think it's a problem to hack around it again. This is originally why our RPC-using test stuff is in a separate crate like this.

@tcharding
Copy link
Member

@benma
Copy link
Contributor Author

benma commented Nov 23, 2023

This new 11.0.0 release depends on bech32-0.10.0-beta, which is marked as unstable on https://docs.rs/bech32/0.10.0-beta/bech32/. Is that a problem? Could bech32 get a new stable release too, or can I rely on the beta as-is?

@apoelstra
Copy link
Member

@benma you can rely on the beta as-is. But in future we'll keep in mind that docs.rs marks beta crates in a scary/annoying way like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants