Make the parse list key to lowercase when insert the keys #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, The patch itself looks good. But I am slowly getting the impression that the whole env-parsing implementation was a mistake. It gets more and more complex. Still, I give this a go for now. |
|
Care to make CI green here? 😃 |
|
sorry，late reply，will let the CI green later: ) |
|
The commit check detail is overdue, could you please approve the workflows? |
|
Done. |
Signed-off-by: bigduu <mugeng.du@qq.com>
|
Thanks, done |
|
do we have any updates? Please help to merge the PR, thanks |
|
Thanks for reminding me! |
|
Np,Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#428