Use weak features for preserve_order #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasbeyer
approved these changes
Sep 25, 2023
|
Unfortunately, CI fails because your commit needs signoff. Please: to fix this. |
Currently, `preserve_order` causes the toml, serde_json and ron dependencies to be enabled. This can be avoided by using cargo's support for [weak features]. [weak features]: https://rust-lang.github.io/rfcs/3143-cargo-weak-namespaced-features.html Weak features were stabilized in Rust 1.60 so there are no MSRV concerns. I think this probably is a breaking change since it's possible some downstream users weren't enabling support explicitly. Signed-off-by: Rain <rain@sunshowers.io>
|
@matthiasbeyer done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
preserve_ordercauses the toml, serde_json and ron dependencies to be enabled. This can be avoided by using cargo's support for weak features.Weak features were stabilized in Rust 1.60 so there are no MSRV concerns.
I think this probably is a breaking change since it's possible some downstream users weren't enabling support explicitly.