Unify deser impl (redux) #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests, in particular, that the error messdage is as expected including the right key and filename. Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
This had open-coded copies of the impl for Value. Replace them with calls to the impl for Value. This reduces duplication. It would allow us to change the impl for Value. Use a macro for the many very-similar functions. Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Closed
matthiasbeyer
approved these changes
Oct 23, 2023
|
I haven't checked yet, but heads-up prior to all the rework done recently to the Might be worth verifying if you've implicitly resolved that issue too, or added more drift 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #338 reworked to apply to current main, and with the test case simplified as requested.