-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for 128x128 size displays #31
Open
JFKingsley
wants to merge
9
commits into
rust-embedded-community:master
Choose a base branch
from
JFKingsley:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8bbb388
Update command.rs
JFKingsley b16fd1a
Update displaysize.rs
JFKingsley 1b377da
Update properties.rs
JFKingsley dd9ac8a
Update properties.rs
JFKingsley 86f673b
Update i2c.rs
JFKingsley 547feea
Update i2c.rs
JFKingsley a2aab8e
Update properties.rs
JFKingsley 645d7ac
Update properties.rs
JFKingsley c95e1c6
Update properties.rs
JFKingsley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,10 +48,12 @@ where | |
let display_rotation = self.display_rotation; | ||
|
||
Command::DisplayOn(false).send(&mut self.iface)?; | ||
Command::DisplayClockDiv(0x8, 0x0).send(&mut self.iface)?; | ||
Command::Multiplex(display_height - 1).send(&mut self.iface)?; | ||
Command::DisplayOffset(0).send(&mut self.iface)?; | ||
Command::StartLine(0).send(&mut self.iface)?; | ||
Command::Contrast(0x80).send(&mut self.iface)?; | ||
Command::SegmentRemap(false).send(&mut self.iface)?; | ||
Command::Multiplex(128).send(&mut self.iface)?; | ||
Command::DisplayOffset(0x60).send(&mut self.iface)?; | ||
Command::DisplayClockDiv(0x8, 0x0).send(&mut self.iface)?; | ||
Comment on lines
+52
to
+56
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't have hardware to test with on hand at the moment, but I'm concerned these changes will cause regressions for the currently supported display sizes. What are the minimum changes needed to support 128x128 displays? |
||
// TODO: Ability to turn charge pump on/off | ||
// Display must be off when performing this command | ||
Command::ChargePump(true).send(&mut self.iface)?; | ||
|
@@ -60,12 +62,13 @@ where | |
|
||
match self.display_size { | ||
DisplaySize::Display128x32 => Command::ComPinConfig(false).send(&mut self.iface), | ||
DisplaySize::Display128x64 | ||
DisplaySize::Display128x128 | ||
| DisplaySize::Display128x64 | ||
| DisplaySize::Display128x64NoOffset | ||
| DisplaySize::Display132x64 => Command::ComPinConfig(true).send(&mut self.iface), | ||
}?; | ||
|
||
Command::Contrast(0x80).send(&mut self.iface)?; | ||
|
||
Command::PreChargePeriod(0x1, 0xF).send(&mut self.iface)?; | ||
Command::VcomhDeselect(VcomhLevel::Auto).send(&mut self.iface)?; | ||
Command::AllOn(false).send(&mut self.iface)?; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming this is the correct offset