From f9f64b9213271e3cf366f862f7db800b5957f2bd Mon Sep 17 00:00:00 2001 From: apiraino Date: Thu, 5 Dec 2024 17:29:53 +0100 Subject: [PATCH] Add t-compiler triage meetings 11/24 --- .../T-compiler Meeting Agenda 2024-11-07.md | 272 ++++++++++++ .../T-compiler Meeting Agenda 2024-11-14.md | 268 ++++++++++++ .../T-compiler Meeting Agenda 2024-11-21.md | 412 ++++++++++++++++++ .../T-compiler Meeting Agenda 2024-11-28.md | 316 ++++++++++++++ 4 files changed, 1268 insertions(+) create mode 100644 content/minutes/triage-meeting/T-compiler Meeting Agenda 2024-11-07.md create mode 100644 content/minutes/triage-meeting/T-compiler Meeting Agenda 2024-11-14.md create mode 100644 content/minutes/triage-meeting/T-compiler Meeting Agenda 2024-11-21.md create mode 100644 content/minutes/triage-meeting/T-compiler Meeting Agenda 2024-11-28.md diff --git a/content/minutes/triage-meeting/T-compiler Meeting Agenda 2024-11-07.md b/content/minutes/triage-meeting/T-compiler Meeting Agenda 2024-11-07.md new file mode 100644 index 00000000..770ef596 --- /dev/null +++ b/content/minutes/triage-meeting/T-compiler Meeting Agenda 2024-11-07.md @@ -0,0 +1,272 @@ +--- +tags: weekly, rustc +type: docs +note_id: OlXkNzCFSpW9wjvvo8bSAw +--- + +# T-compiler Meeting Agenda 2024-11-07 + +## Announcements + +- Steering meeting: planning tomorrow at +- Reminder: if you see a PR/issue that seems like there might be legal implications due to copyright/IP/etc, please let us know (or at least message @_**davidtwco** or @_**Wesley Wiser** so we can pass it along). + +### Other WG meetings + +- Types Team: ITE (Impl Trait Everywhere) Triage + +## MCPs/FCPs + +- New MCPs (take a look, see if you like them!) + - "Unstable flag to choose Emscripten unwinding abi" [compiler-team#801](https://github.com/rust-lang/compiler-team/issues/801) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Unstable.20flag.20to.20choose.20Emscripten.20unwind.E2.80.A6.20compiler-team.23801)) + - "Allow users to specify the TLS dialect (Traditional TLS vs. TLSDESC)" [compiler-team#805](https://github.com/rust-lang/compiler-team/issues/805) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Allow.20users.20to.20specify.20the.20TLS.20dialect.20.28T.E2.80.A6.20compiler-team.23805)) +- Old MCPs (stale MCP might be closed as per [MCP procedure](https://forge.rust-lang.org/compiler/mcp.html#when-should-major-change-proposals-be-closed)) + - None at this time +- Old MCPs (not seconded, take a look) + - "Add hygiene attributes to compile expanded source code" [compiler-team#692](https://github.com/rust-lang/compiler-team/issues/692) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Add.20option.20to.20compile.20expanded.20ASTs.20for.20h.E2.80.A6.20compiler-team.23692)) (last review activity: about 49 days ago) + - "Add Hotpatch flag" [compiler-team#745](https://github.com/rust-lang/compiler-team/issues/745) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Add.20Hotpatch.20flag.20compiler-team.23745)) (last review activity: about 27 days ago) + - "Add `evex512` target feature for AVX10" [compiler-team#778](https://github.com/rust-lang/compiler-team/issues/778) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Add.20.60evex512.60.20target.20feature.20for.20AVX10.20compiler-team.23778)) (last review activity: 2 months ago) + - "Make the test cfg a userspace check-cfg" [compiler-team#785](https://github.com/rust-lang/compiler-team/issues/785) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Make.20the.20test.20cfg.20a.20userspace.20check-cfg.20compiler-team.23785)) (last review activity: about 14 days ago) + - "Policy change around adding new unstable flags" [compiler-team#787](https://github.com/rust-lang/compiler-team/issues/787) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Policy.20change.20around.20adding.20new.20unstable.20.E2.80.A6.20compiler-team.23787)) (last review activity: about 20 days ago) + - "Normalize FileCheck directives" [compiler-team#789](https://github.com/rust-lang/compiler-team/issues/789) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Normalize.20FileCheck.20directives.20compiler-team.23789)) (last review activity: about 20 days ago) + - "Relink, don't rebuild" [compiler-team#790](https://github.com/rust-lang/compiler-team/issues/790) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Relink.2C.20don.27t.20rebuild.20compiler-team.23790)) (last review activity: about 20 days ago) + - "Support for a new `wasm32-linux-musl` Tier-3 target" [compiler-team#797](https://github.com/rust-lang/compiler-team/issues/797) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Support.20for.20a.20new.20.60wasm32-linux-musl.60.20Tie.E2.80.A6.20compiler-team.23797)) (last review activity: about 20 days ago) + - "Create an avr-unknown-unknown target" [compiler-team#800](https://github.com/rust-lang/compiler-team/issues/800) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Create.20an.20avr-unknown-unknown.20target.20compiler-team.23800)) (last review activity: about 6 days ago) +- Pending FCP requests (check your boxes!) + - "sanitizers: Stabilize AddressSanitizer and LeakSanitizer for the Tier 1 targets" [rust#123617](https://github.com/rust-lang/rust/pull/123617) + - "Lint on combining `#[no_mangle]` and `#[export_name]`" [rust#131558](https://github.com/rust-lang/rust/pull/131558) +- Things in FCP (make sure you're good with it) + - "Promote powerpc64le-unknown-linux-musl to tier 2" [compiler-team#803](https://github.com/rust-lang/compiler-team/issues/803) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Promote.20powerpc64le-unknown-linux-musl.20to.E2.80.A6.20compiler-team.23803)) + - "Fix ICE when passing DefId-creating args to legacy_const_generics." [rust#130443](https://github.com/rust-lang/rust/pull/130443) + - "Stabilize WebAssembly `multivalue`, `reference-types`, and `tail-call` target features" [rust#131080](https://github.com/rust-lang/rust/pull/131080) + - "Reject raw lifetime followed by `'`, like regular lifetimes do" [rust#132341](https://github.com/rust-lang/rust/pull/132341) +- Accepted MCPs + - No new accepted proposals this time. +- MCPs blocked on unresolved concerns + - "Retire the mailing list and make all decisions on zulip" [compiler-team#649](https://github.com/rust-lang/compiler-team/issues/649) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Retire.20the.20mailing.20list.20and.20make.20all.20deci.E2.80.A6.20compiler-team.23649)) + - concern: [automatic-sync](https://github.com/rust-lang/compiler-team/issues/649#issuecomment-1618902660) +- Finalized FCPs (disposition merge) + - "Add `--print host-tuple` to print host target tuple" [rust#125579](https://github.com/rust-lang/rust/pull/125579) + - "make unsupported_calling_conventions a hard error" [rust#129935](https://github.com/rust-lang/rust/pull/129935) +- Other teams finalized FCPs + - "Add lint against function pointer comparisons" [rust#118833](https://github.com/rust-lang/rust/pull/118833) + - "Fixup Windows verbatim paths when used with the `include!` macro" [rust#125205](https://github.com/rust-lang/rust/pull/125205) + - "Allow dropping `dyn Trait` principal" [rust#126660](https://github.com/rust-lang/rust/pull/126660) + - "Lint against `&T` to `&mut T` and `&T` to `&UnsafeCell` transmutes" [rust#128351](https://github.com/rust-lang/rust/pull/128351) + - "atomics: allow atomic and non-atomic reads to race" [rust#128778](https://github.com/rust-lang/rust/pull/128778) + - "Lint against getting pointers from immediately dropped temporaries" [rust#128985](https://github.com/rust-lang/rust/pull/128985) + - "#[inline(never)] does not work for async functions" [rust#129347](https://github.com/rust-lang/rust/issues/129347) + - "Do not consider match/let/ref of place that evaluates to `!` to diverge, disallow coercions from them too" [rust#129392](https://github.com/rust-lang/rust/pull/129392) + - "Make deprecated_cfg_attr_crate_type_name a hard error" [rust#129670](https://github.com/rust-lang/rust/pull/129670) + - "Stabilize expr_2021 fragment specifier in all editions" [rust#129972](https://github.com/rust-lang/rust/pull/129972) + - "Check elaborated projections from dyn don't mention unconstrained late bound lifetimes" [rust#130367](https://github.com/rust-lang/rust/pull/130367) + - "Finish stabilization of `result_ffi_guarantees`" [rust#130628](https://github.com/rust-lang/rust/pull/130628) + - "Stabilize const `ptr::write*` and `mem::replace`" [rust#130954](https://github.com/rust-lang/rust/pull/130954) + - "Decide whether blocks inside `asm` goto should default to safe" [rust#132078](https://github.com/rust-lang/rust/issues/132078) + +## Backport nominations + +[T-compiler beta](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Abeta-nominated+-label%3Abeta-accepted+label%3AT-compiler) / [T-compiler stable](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Astable-nominated+-label%3Astable-accepted+label%3AT-compiler) +- :beta: "Also treat `impl` definition parent as transparent regarding modules" [rust#132453](https://github.com/rust-lang/rust/pull/132453) + - Authored by Urgau + - Fixes P-low #132427, when a `const` was generated in a proc-macro + +- :beta: "Revert "Avoid nested replacement ranges" from #129346." [rust#132587](https://github.com/rust-lang/rust/pull/132587) + - Authored by nnethercote + - Complements #129346 (which fixes some regressions found in a crater run for 1.83, see [comment](https://github.com/rust-lang/rust/pull/132587#issuecomment-2455880992)) + +- No stable nominations for `T-compiler` this time. + +[T-types stable](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Abeta-nominated+-label%3Abeta-accepted+label%3AT-types) / [T-types beta](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Astable-nominated+-label%3Astable-accepted+label%3AT-types) +- No beta nominations for `T-types` this time. +- No stable nominations for `T-types` this time. + +## PRs S-waiting-on-team + +[T-compiler](https://github.com/rust-lang/rust/pulls?q=is%3Aopen+label%3AS-waiting-on-team+label%3AT-compiler) +- [Issues in progress or waiting on other teams](https://hackmd.io/XYr1BrOWSiqCrl8RCWXRaQ) + +## Issues of Note + +### Short Summary + +- [1 T-compiler P-critical issues](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-compiler+label%3AP-critical) + - [0 of those are unassigned](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-compiler+label%3AP-critical+no%3Aassignee) +- [70 T-compiler P-high issues](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-compiler+label%3AP-high) + - [43 of those are unassigned](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-compiler+label%3AP-high+no%3Aassignee) +- [0 P-critical, 0 P-high, 2 P-medium, 1 P-low regression-from-stable-to-beta](https://github.com/rust-lang/rust/labels/regression-from-stable-to-beta) +- [0 P-critical, 0 P-high, 5 P-medium, 2 P-low regression-from-stable-to-nightly](https://github.com/rust-lang/rust/labels/regression-from-stable-to-nightly) +- [1 P-critical, 38 P-high, 100 P-medium, 17 P-low regression-from-stable-to-stable](https://github.com/rust-lang/rust/labels/regression-from-stable-to-stable) + +### P-critical + +[T-compiler](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AP-critical+label%3AT-compiler) +- "[Regression] LLVM asserts "conflicting locations for variable" since 1.82" [rust#131944](https://github.com/rust-lang/rust/issues/131944) + - Fedora Core 39 CI does not build anymore (uses LLVM 17) + - Will be fixed by #132613, still in draft (unsure why) + +[T-types](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AP-critical+label%3AT-types) +- No `P-critical` issues for `T-types` this time. + +### P-high regressions + +[P-high stable regressions](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3Aregression-from-stable-to-stable+label%3AP-high+-label%3AT-infra+-label%3AT-libs+-label%3AT-libs-api+-label%3AT-release+-label%3AT-rustdoc+-label%3AT-core) +- "Hang after encountering overflow errors for huge types" [rust#132673](https://github.com/rust-lang/rust/issues/132673) + - Traits rework in #119989 seems to cause an infinite recursion in some cases (see [comment](https://github.com/rust-lang/rust/issues/132673#issuecomment-2459836923)) + - On stable since 1.78. Though the repro is quite simple, seems was not yet reported + - Is this a P-high or can be downgraded? + +[P-high beta regressions](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3Aregression-from-stable-to-beta+label%3AP-high+-label%3AT-infra+-label%3AT-libs+-label%3AT-libs-api+-label%3AT-release+-label%3AT-rustdoc+-label%3AT-core) +- No `P-high` beta regressions this time. + +[Unassigned P-high nightly regressions](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3Aregression-from-stable-to-nightly+label%3AP-high+no%3Aassignee+-label%3AT-infra+-label%3AT-libs+-label%3AT-libs-api+-label%3AT-release+-label%3AT-rustdoc+-label%3AT-core+) +- No unassigned `P-high` nightly regressions this time. + +## Performance logs + +> [triage logs for 2024-11-05](https://github.com/rust-lang/rustc-perf/blob/master/triage/2024-11-05.md) + +A week dominated by one large improvement and one large regression where luckily the improvement had a larger impact. The regression seems to have been caused by a newly introduced lint that might have performance issues. The improvement was in building rustc with protected visibility which reduces the number of dynamic relocations needed leading to some nice performance gains. Across a large swath of the perf suite, the compiler is on average 1% faster after this week compared to last week. + +Triage done by **@rylev**. +Revision range: [c8a8c820..27e38f8f](https://perf.rust-lang.org/?start=c8a8c82035439cb2404b8f24ca0bc18209d534ca&end=27e38f8fc7efc57b75e9a763d7a0ee44822cd5f7&absolute=false&stat=instructions%3Au) + +**Summary**: + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:---------------:|:-----:| +| Regressions (primary) | 0.8% | [0.1%, 2.0%] | 80 | +| Regressions (secondary) | 1.9% | [0.2%, 3.4%] | 45 | +| Improvements (primary) | -1.9% | [-31.6%, -0.1%] | 148 | +| Improvements (secondary) | -5.1% | [-27.8%, -0.1%] | 180 | +| All (primary) | -1.0% | [-31.6%, 2.0%] | 228 | + + +1 Regression, 1 Improvement, 5 Mixed; 3 of them in rollups +46 artifact comparisons made in total + +#### Regressions + +Rollup of 6 pull requests [#132326](https://github.com/rust-lang/rust/pull/132326) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e473783d90e2289b8a97575fa60d6315f0a318eb&end=1e4f10ba6476e48a42a79b9f846a2d9366525b9e&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:----:|:------------:|:-----:| +| Regressions (primary) | 0.7% | [0.2%, 1.9%] | 104 | +| Regressions (secondary) | 1.5% | [0.1%, 4.4%] | 68 | +| Improvements (primary) | - | - | 0 | +| Improvements (secondary) | - | - | 0 | +| All (primary) | 0.7% | [0.2%, 1.9%] | 104 | +- Fairly large regression caused by https://github.com/rust-lang/rust/pull/131984. +- Most likely due to a non-performant lint being run that wasn't previously. +- Checked with the author and reviewer. + + +#### Improvements + +Use protected visibility when building rustc with LLD [#131634](https://github.com/rust-lang/rust/pull/131634) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a8e1186e3c14a54f7a38cc1183117dc7e77f4f82&end=9fa9ef385c0aad8f5d4c8f7d92dca474367943a3&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:---------------:|:-----:| +| Regressions (primary) | - | - | 0 | +| Regressions (secondary) | - | - | 0 | +| Improvements (primary) | -1.8% | [-31.3%, -0.1%] | 174 | +| Improvements (secondary) | -4.2% | [-27.5%, -0.2%] | 224 | +| All (primary) | -1.8% | [-31.3%, -0.1%] | 174 | + + +#### Mixed + +Rollup of 12 pull requests [#132317](https://github.com/rust-lang/rust/pull/132317) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c8a8c82035439cb2404b8f24ca0bc18209d534ca&end=2dece5bb62f234f5622a08289c5a3d1555cd7843&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 0.2% | [0.2%, 0.4%] | 4 | +| Regressions (secondary) | 0.2% | [0.2%, 0.2%] | 1 | +| Improvements (primary) | -0.2% | [-0.4%, -0.1%] | 6 | +| Improvements (secondary) | -0.3% | [-0.3%, -0.3%] | 1 | +| All (primary) | -0.0% | [-0.4%, 0.4%] | 10 | +- Looks like a bit more time spent in LLVM? Might have been caused by a few PRs in this rollup, but the total result is a wash, so I don't think it's needed to dig deeper into this. + + +Rc/Arc: don't leak the allocation if drop panics [#132231](https://github.com/rust-lang/rust/pull/132231) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=2dece5bb62f234f5622a08289c5a3d1555cd7843&end=e473783d90e2289b8a97575fa60d6315f0a318eb&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 0.6% | [0.6%, 0.6%] | 1 | +| Regressions (secondary) | 2.3% | [1.1%, 3.5%] | 6 | +| Improvements (primary) | -0.9% | [-1.4%, -0.3%] | 3 | +| Improvements (secondary) | -0.4% | [-0.6%, -0.2%] | 5 | +| All (primary) | -0.5% | [-1.4%, 0.6%] | 4 | +- There probably isn't too much to be done regarding perf, all of the major regressions come from one small stress test crate. + + +Mark `simplify_aggregate_to_copy` mir-opt as unsound [#132356](https://github.com/rust-lang/rust/pull/132356) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=20c909ff9cdd88d33768a4ddb8952927a675b0ad&end=a0d98ff0e5b6e1f2c63fd26f68484792621b235c&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 0.7% | [0.3%, 1.9%] | 14 | +| Regressions (secondary) | 0.7% | [0.2%, 2.3%] | 16 | +| Improvements (primary) | -0.3% | [-0.3%, -0.3%] | 1 | +| Improvements (secondary) | -0.3% | [-0.4%, -0.3%] | 5 | +| All (primary) | 0.7% | [-0.3%, 1.9%] | 15 | +- This deactivated an unsound MIR optimization until it is fixed. + + +add const_panic macro to make it easier to fall back to non-formatting panic in const [#132542](https://github.com/rust-lang/rust/pull/132542) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7028d9318fadc20e5e3058d52e44d785d31a6aaa&end=e3a918ece026cec748fc64af5b4983095b46097e&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 0.8% | [0.2%, 1.8%] | 6 | +| Regressions (secondary) | - | - | 0 | +| Improvements (primary) | -0.5% | [-0.9%, -0.1%] | 5 | +| Improvements (secondary) | - | - | 0 | +| All (primary) | 0.2% | [-0.9%, 1.8%] | 11 | +- Looks like most of the regressions are taking longer in LLVM related queries (e.g., LLVM_module_codegen_emit_obj) which doesn't make a ton of sense to me. + + +Rollup of 11 pull requests [#132626](https://github.com/rust-lang/rust/pull/132626) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=96477c55bcfa7121470ed225f602c1c639aeaa18&end=27e38f8fc7efc57b75e9a763d7a0ee44822cd5f7&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | - | - | 0 | +| Regressions (secondary) | 0.6% | [0.5%, 0.9%] | 7 | +| Improvements (primary) | - | - | 0 | +| Improvements (secondary) | -0.3% | [-0.3%, -0.3%] | 2 | +| All (primary) | - | - | 0 | +- It's not obvious to me which PR might be the culprit here and the regression is small and contained enough that I don't think it's worth investigating. + +## Nominated Issues + +- GSoC blog post PR needs an r+ from a team lead: + +[T-compiler](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AI-compiler-nominated) +- No I-compiler-nominated issues this time. + +[RFC](https://github.com/rust-lang/rfcs/issues?q=is%3Aopen+label%3AI-compiler-nominated) +- No I-compiler-nominated RFCs this time. + +### Oldest PRs waiting for review + +[T-compiler](https://github.com/rust-lang/rust/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-asc+label%3AS-waiting-on-review+draft%3Afalse+label%3AT-compiler) +- "sess: stabilize `-C stack-protector=all`" [rust#121742](https://github.com/rust-lang/rust/pull/121742) + - Unsure about current status? cc @**Wesley Wiser** do you have some context here? +- "Do not eagerly reject inference vars when trying to resolve method calls." [rust#126316](https://github.com/rust-lang/rust/pull/126316) + - Any news cc @**lcnr** (re: talk with @_**oli**, see [comment](https://rust-lang.zulipchat.com/#narrow/channel/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202024-10-17/near/477499929)) +- "Initial support for auto traits with default bounds" [rust#120706](https://github.com/rust-lang/rust/pull/120706) (last review activity: 3 months ago) + - perhaps cc @**Michael Goulet (compiler-errors)** @**Vadim Petrochenkov** since commented (modulo a rebase) +- "Fix crate name validation" [rust#127581](https://github.com/rust-lang/rust/pull/127581) (last review activity: 3 months ago) + - cc @**Wesley Wiser** +- "Remove -Zfuel." [rust#115293](https://github.com/rust-lang/rust/pull/115293) + - cc @**Wesley Wiser** another one for you + +Next meetings' agenda draft: [hackmd link](https://hackmd.io/QE5KGxFPS4Wdi06prp3n0A) diff --git a/content/minutes/triage-meeting/T-compiler Meeting Agenda 2024-11-14.md b/content/minutes/triage-meeting/T-compiler Meeting Agenda 2024-11-14.md new file mode 100644 index 00000000..f553c194 --- /dev/null +++ b/content/minutes/triage-meeting/T-compiler Meeting Agenda 2024-11-14.md @@ -0,0 +1,268 @@ +--- +tags: weekly, rustc +type: docs +note_id: QE5KGxFPS4Wdi06prp3n0A +--- + +# T-compiler Meeting Agenda 2024-11-14 + +## Announcements + +- Rustc Dev Guide reading club session, chapters 40 to 42 on . More information #**t-compiler/wg-rustc-dev-guide>Rustc dev guide reading club**. +- Reminder: if you see a PR/issue that seems like there might be legal implications due to copyright/IP/etc, please let us know (or at least message @_**davidtwco** or @_**Wesley Wiser** so we can pass it along). + +### Other WG meetings + +- Types Team: Types Team High Bandwidth Discussions +- Compiler Team: P-high review + +## MCPs/FCPs + +- New MCPs (take a look, see if you like them!) + - "Unstable flag to choose Emscripten unwinding abi" [compiler-team#801](https://github.com/rust-lang/compiler-team/issues/801) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Unstable.20flag.20to.20choose.20Emscripten.20unwind.E2.80.A6.20compiler-team.23801)) + - "Allow users to specify the TLS dialect (Traditional TLS vs. TLSDESC)" [compiler-team#805](https://github.com/rust-lang/compiler-team/issues/805) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Allow.20users.20to.20specify.20the.20TLS.20dialect.20.28T.E2.80.A6.20compiler-team.23805)) +- Old MCPs (stale MCP might be closed as per [MCP procedure](https://forge.rust-lang.org/compiler/mcp.html#when-should-major-change-proposals-be-closed)) + - None at this time +- Old MCPs (not seconded, take a look) + - "Add hygiene attributes to compile expanded source code" [compiler-team#692](https://github.com/rust-lang/compiler-team/issues/692) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Add.20option.20to.20compile.20expanded.20ASTs.20for.20h.E2.80.A6.20compiler-team.23692)) (last review activity: about 55 days ago) + - "Add Hotpatch flag" [compiler-team#745](https://github.com/rust-lang/compiler-team/issues/745) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Add.20Hotpatch.20flag.20compiler-team.23745)) (last review activity: about 33 days ago) + - "Add `evex512` target feature for AVX10" [compiler-team#778](https://github.com/rust-lang/compiler-team/issues/778) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Add.20.60evex512.60.20target.20feature.20for.20AVX10.20compiler-team.23778)) (last review activity: 2 months ago) + - "Make the test cfg a userspace check-cfg" [compiler-team#785](https://github.com/rust-lang/compiler-team/issues/785) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Make.20the.20test.20cfg.20a.20userspace.20check-cfg.20compiler-team.23785)) (last review activity: about 4 days ago) + - "Policy change around adding new unstable flags" [compiler-team#787](https://github.com/rust-lang/compiler-team/issues/787) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Policy.20change.20around.20adding.20new.20unstable.20.E2.80.A6.20compiler-team.23787)) (last review activity: about 27 days ago) + - "Normalize FileCheck directives" [compiler-team#789](https://github.com/rust-lang/compiler-team/issues/789) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Normalize.20FileCheck.20directives.20compiler-team.23789)) (last review activity: about 27 days ago) + - "Relink, don't rebuild" [compiler-team#790](https://github.com/rust-lang/compiler-team/issues/790) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Relink.2C.20don.27t.20rebuild.20compiler-team.23790)) (last review activity: about 27 days ago) + - "Support for a new `wasm32-wali-linux-musl` Tier-3 target" [compiler-team#797](https://github.com/rust-lang/compiler-team/issues/797) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Support.20for.20a.20new.20.60wasm32-linux-musl.60.20Tie.E2.80.A6.20compiler-team.23797)) (last review activity: about 0 days ago) + - Note: this could probably be easily seconded, target name discussion already happened + - "Create an avr-unknown-none target" [compiler-team#800](https://github.com/rust-lang/compiler-team/issues/800) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Create.20an.20avr-unknown-unknown.20target.20compiler-team.23800)) (last review activity: about 4 days ago) +- Pending FCP requests (check your boxes!) + - "sanitizers: Stabilize AddressSanitizer and LeakSanitizer for the Tier 1 targets" [rust#123617](https://github.com/rust-lang/rust/pull/123617) + - "Lint on combining `#[no_mangle]` and `#[export_name]`" [rust#131558](https://github.com/rust-lang/rust/pull/131558) +- Things in FCP (make sure you're good with it) + - "Promote powerpc64le-unknown-linux-musl to tier 2" [compiler-team#803](https://github.com/rust-lang/compiler-team/issues/803) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Promote.20powerpc64le-unknown-linux-musl.20to.E2.80.A6.20compiler-team.23803)) +- Accepted MCPs + - No new accepted proposals this time. +- MCPs blocked on unresolved concerns + - "Retire the mailing list and make all decisions on zulip" [compiler-team#649](https://github.com/rust-lang/compiler-team/issues/649) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Retire.20the.20mailing.20list.20and.20make.20all.20deci.E2.80.A6.20compiler-team.23649)) + - concern: [automatic-sync](https://github.com/rust-lang/compiler-team/issues/649#issuecomment-1618902660) +- Finalized FCPs (disposition merge) + - "Add `--print host-tuple` to print host target tuple" [rust#125579](https://github.com/rust-lang/rust/pull/125579) + - "make unsupported_calling_conventions a hard error" [rust#129935](https://github.com/rust-lang/rust/pull/129935) + - "Fix ICE when passing DefId-creating args to legacy_const_generics." [rust#130443](https://github.com/rust-lang/rust/pull/130443) + - "Stabilize WebAssembly `multivalue`, `reference-types`, and `tail-call` target features" [rust#131080](https://github.com/rust-lang/rust/pull/131080) +- Other teams finalized FCPs + - "Fixup Windows verbatim paths when used with the `include!` macro" [rust#125205](https://github.com/rust-lang/rust/pull/125205) + - "Allow dropping `dyn Trait` principal" [rust#126660](https://github.com/rust-lang/rust/pull/126660) + - "Lint against `&T` to `&mut T` and `&T` to `&UnsafeCell` transmutes" [rust#128351](https://github.com/rust-lang/rust/pull/128351) + - "atomics: allow atomic and non-atomic reads to race" [rust#128778](https://github.com/rust-lang/rust/pull/128778) + - "Lint against getting pointers from immediately dropped temporaries" [rust#128985](https://github.com/rust-lang/rust/pull/128985) + - "#[inline(never)] does not work for async functions" [rust#129347](https://github.com/rust-lang/rust/issues/129347) + - "Do not consider match/let/ref of place that evaluates to `!` to diverge, disallow coercions from them too" [rust#129392](https://github.com/rust-lang/rust/pull/129392) + - "Make deprecated_cfg_attr_crate_type_name a hard error" [rust#129670](https://github.com/rust-lang/rust/pull/129670) + - "Stabilize expr_2021 fragment specifier in all editions" [rust#129972](https://github.com/rust-lang/rust/pull/129972) + - "Check elaborated projections from dyn don't mention unconstrained late bound lifetimes" [rust#130367](https://github.com/rust-lang/rust/pull/130367) + - "Finish stabilization of `result_ffi_guarantees`" [rust#130628](https://github.com/rust-lang/rust/pull/130628) + - "Stabilize const `ptr::write*` and `mem::replace`" [rust#130954](https://github.com/rust-lang/rust/pull/130954) + - "Stabilize s390x inline assembly" [rust#131258](https://github.com/rust-lang/rust/pull/131258) + - "Stabilize Arm64EC inline assembly" [rust#131781](https://github.com/rust-lang/rust/pull/131781) + - "Decide whether blocks inside `asm` goto should default to safe" [rust#132078](https://github.com/rust-lang/rust/issues/132078) + - "Enforce that raw lifetimes must be valid raw identifiers" [rust#132363](https://github.com/rust-lang/rust/pull/132363) + +## Backport nominations + +[T-compiler beta](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Abeta-nominated+-label%3Abeta-accepted+label%3AT-compiler) / [T-compiler stable](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Astable-nominated+-label%3Astable-accepted+label%3AT-compiler) +- :beta: "Add discriminators to DILocations when multiple functions are inlined into a single point." [rust#132613](https://github.com/rust-lang/rust/pull/132613) + - Authored by khuey + - Fixes #131944, rated P-critical because it broke a Fedora CI + - Seems like nobody else reported it from happening, also see [comment](https://github.com/rust-lang/rust/pull/132613#issuecomment-2465924896) + - Note: #132900 (ICE without a repro) was opened 3 days ago, reporter suspects being caused by #132613. Codebase is private, we didn't hear from them yet. + +- :beta: "Only disable cache if predicate has opaques within it" [rust#132625](https://github.com/rust-lang/rust/pull/132625) + - Authored by compiler-errors + - Improves a substancial compile time regression introduced in 1.82 (#132064) + - we're not completely back at compile time before 1.82 (more specifically after #126024), see [comment](https://github.com/rust-lang/rust/issues/132064#issuecomment-2465947310) + +- :stable: "Only disable cache if predicate has opaques within it" [rust#132625](https://github.com/rust-lang/rust/pull/132625) + - see above + + +[T-types stable](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Abeta-nominated+-label%3Abeta-accepted+label%3AT-types) / [T-types beta](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Astable-nominated+-label%3Astable-accepted+label%3AT-types) +- No beta nominations for `T-types` this time. +- No stable nominations for `T-types` this time. + +## PRs S-waiting-on-team + +[T-compiler](https://github.com/rust-lang/rust/pulls?q=is%3Aopen+label%3AS-waiting-on-team+label%3AT-compiler) +- [Issues in progress or waiting on other teams](https://hackmd.io/XYr1BrOWSiqCrl8RCWXRaQ) + +## Issues of Note + +### Short Summary + +- [0 T-compiler P-critical issues](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-compiler+label%3AP-critical) + - [0 of those are unassigned](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-compiler+label%3AP-critical+no%3Aassignee) +- [69 T-compiler P-high issues](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-compiler+label%3AP-high) + - [41 of those are unassigned](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-compiler+label%3AP-high+no%3Aassignee) +- [0 P-critical, 0 P-high, 2 P-medium, 1 P-low regression-from-stable-to-beta](https://github.com/rust-lang/rust/labels/regression-from-stable-to-beta) +- [0 P-critical, 0 P-high, 5 P-medium, 2 P-low regression-from-stable-to-nightly](https://github.com/rust-lang/rust/labels/regression-from-stable-to-nightly) +- [0 P-critical, 38 P-high, 100 P-medium, 17 P-low regression-from-stable-to-stable](https://github.com/rust-lang/rust/labels/regression-from-stable-to-stable) + +### P-critical + +[T-compiler](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AP-critical+label%3AT-compiler) +- No `P-critical` issues for `T-compiler` this time. + +[T-types](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AP-critical+label%3AT-types) +- No `P-critical` issues for `T-types` this time. + +### P-high regressions + +[P-high beta regressions](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3Aregression-from-stable-to-beta+label%3AP-high+-label%3AT-infra+-label%3AT-libs+-label%3AT-libs-api+-label%3AT-release+-label%3AT-rustdoc+-label%3AT-core) +- No `P-high` beta regressions this time. + +[Unassigned P-high nightly regressions](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3Aregression-from-stable-to-nightly+label%3AP-high+no%3Aassignee+-label%3AT-infra+-label%3AT-libs+-label%3AT-libs-api+-label%3AT-release+-label%3AT-rustdoc+-label%3AT-core+) +- No unassigned `P-high` nightly regressions this time. + +## Performance logs + +> [triage logs 2024-11-11](https://github.com/rust-lang/rustc-perf/blob/master/triage/2024-11-11.md) + +Regressions primarily in doc builds. No significant changes in cycle or max-rss +counts. + +Triage done by **@simulacrum**. +Revision range: [27e38f8f..d4822c2d](https://perf.rust-lang.org/?start=27e38f8fc7efc57b75e9a763d7a0ee44822cd5f7&end=d4822c2d84c242cc7403118b50c571464f38ef8f&absolute=false&stat=instructions%3Au) + +**Summary**: + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 0.5% | [0.2%, 1.0%] | 61 | +| Regressions (secondary) | 0.9% | [0.2%, 1.5%] | 30 | +| Improvements (primary) | -2.9% | [-5.0%, -0.6%] | 7 | +| Improvements (secondary) | -1.5% | [-5.0%, -0.2%] | 28 | +| All (primary) | 0.1% | [-5.0%, 1.0%] | 68 | + +1 Regressions, 1 Improvements, 4 Mixed; 1 of them in rollups +47 artifact comparisons made in total + +#### Regressions + +Clean middle generics using paren sugar if trait has `#[rustc_paren_sugar]` [#132697](https://github.com/rust-lang/rust/pull/132697) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4d215e2426d52ca8d1af166d5f6b5e172afbff67&end=116fc31c5c82b7767c87101164a1afa3faea97fd&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:----:|:------------:|:-----:| +| Regressions (primary) | 0.2% | [0.1%, 0.4%] | 8 | +| Regressions (secondary) | 0.3% | [0.2%, 0.4%] | 16 | +| Improvements (primary) | - | - | 0 | +| Improvements (secondary) | - | - | 0 | +| All (primary) | 0.2% | [0.1%, 0.4%] | 8 | + +Doc-only regressions, no fix directly planned (prioritizing code clarity), but +inspired some unrelated cleanup in +https://github.com/rust-lang/rust/pull/132886. + +rustdoc-search: simplify rules for generics and type params [#127589](https://github.com/rust-lang/rust/pull/127589) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=71042b4b201a432b426304f511b3169850ed8923&end=d4822c2d84c242cc7403118b50c571464f38ef8f&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 0.2% | [0.1%, 0.5%] | 15 | +| Regressions (secondary) | 0.4% | [0.1%, 0.5%] | 19 | +| Improvements (primary) | - | - | 0 | +| Improvements (secondary) | -2.4% | [-2.4%, -2.4%] | 1 | +| All (primary) | 0.2% | [0.1%, 0.5%] | 15 | + +Doc-only regressions, likely genuine given the change. + +#### Improvements + +Only disable cache if predicate has opaques within it [#132625](https://github.com/rust-lang/rust/pull/132625) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8549802939cd01111c46e34a7b67cb1933977af9&end=c07aa1e17199e27f6f7ac8f3307bca7bda0084b6&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | - | - | 0 | +| Regressions (secondary) | - | - | 0 | +| Improvements (primary) | -2.7% | [-5.0%, -0.2%] | 7 | +| Improvements (secondary) | -3.0% | [-5.1%, -0.3%] | 10 | +| All (primary) | -2.7% | [-5.0%, -0.2%] | 7 | +- Note from @_*apiraino*: #132625 recovered most of a substancial regression introduced in #126024 + +#### Mixed + +Add new unstable feature `const_eq_ignore_ascii_case` [#131721](https://github.com/rust-lang/rust/pull/131721) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e1fb28856267e3cbfd1ea479e666ce25d67fea29&end=279604832887abeaea0cb31c20590c43dea497ae&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 0.2% | [0.2%, 0.2%] | 1 | +| Regressions (secondary) | - | - | 0 | +| Improvements (primary) | -0.5% | [-0.7%, -0.1%] | 4 | +| Improvements (secondary) | - | - | 0 | +| All (primary) | -0.3% | [-0.7%, 0.2%] | 5 | + +Probably mostly luck of some kind, change itself is library-only. + +Emit warning when calling/declaring functions with unavailable vectors. [#132173](https://github.com/rust-lang/rust/pull/132173) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=303fc0527aea5c7e9bbef97da926639e1ade3399&end=7660aed73d5233fdd1ff2651fc8a6acab1b61691&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 0.5% | [0.2%, 1.0%] | 36 | +| Regressions (secondary) | 0.6% | [0.2%, 0.9%] | 6 | +| Improvements (primary) | -0.4% | [-0.4%, -0.4%] | 1 | +| Improvements (secondary) | -0.1% | [-0.1%, -0.1%] | 1 | +| All (primary) | 0.5% | [-0.4%, 1.0%] | 37 | + +Regression, but a bunch of optimization work already went into it (see +https://github.com/rust-lang/rust/pull/132173#issuecomment-2466642549). + +Rollup of 6 pull requests [#132831](https://github.com/rust-lang/rust/pull/132831) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7660aed73d5233fdd1ff2651fc8a6acab1b61691&end=668959740f97e7a22ae340742886d330ab63950f&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | - | - | 0 | +| Regressions (secondary) | 1.4% | [1.3%, 1.5%] | 6 | +| Improvements (primary) | - | - | 0 | +| Improvements (secondary) | -0.7% | [-1.4%, -0.2%] | 13 | +| All (primary) | - | - | 0 | + +Queued up one trial build. Likely a real regression, but not necessarily worth +digging deeper given limited impact (few benchmarks). + +## Nominated Issues + +[T-compiler](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AI-compiler-nominated) +- None + +[RFC](https://github.com/rust-lang/rfcs/issues?q=is%3Aopen+label%3AI-compiler-nominated) +- No I-compiler-nominated RFCs this time. + +### Oldest PRs waiting for review + +[T-compiler](https://github.com/rust-lang/rust/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-asc+label%3AS-waiting-on-review+draft%3Afalse+label%3AT-compiler) +- "Allow a MIR analysis to perform the state `join` directly" [rust#114900](https://github.com/rust-lang/rust/pull/114900) + - cc @**cjgillot** PR author added some more context. This work has been in progress since a bit. Can we get an update so that is clear what it needs to be done or - else - if we think this contribution is not needed (as hinted at [this comment](https://github.com/rust-lang/rust/pull/114900#issuecomment-1748702938))? Thanks! + - Ref. also the Clippy patch: https://github.com/rust-lang/rust-clippy/pull/11364 +- "Skip locking span interner for some syntax context checks" [rust#128197](https://github.com/rust-lang/rust/pull/128197) (last review activity: 3 months ago) + - cc: @**davidtwco** +- "Implement a lint for implicit autoref of raw pointer dereference - take 2" [rust#123239](https://github.com/rust-lang/rust/pull/123239) (last review activity: 3 months ago) + - cc: @**lcnr** did you have a chance to talk with @_**oli** (mentioned in [comment](https://rust-lang.zulipchat.com/#narrow/channel/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202024-10-17/near/477499929)) +- "When annotations needed, look at impls for more accurate suggestions " [rust#128653](https://github.com/rust-lang/rust/pull/128653) (last review activity: 2 months ago) + - cc: @**Michael Goulet (compiler-errors)** (afaics all your comments are addressed) +- "Improve dead code analysis for structs and traits defined locally" [rust#128637](https://github.com/rust-lang/rust/pull/128637) (last review activity: 2 months ago) + - cc: @cjgillot + +Next meeting's agenda draft: [hackmd link](https://hackmd.io/AIoQaNMuSwOQ0UCkX38lZQ) diff --git a/content/minutes/triage-meeting/T-compiler Meeting Agenda 2024-11-21.md b/content/minutes/triage-meeting/T-compiler Meeting Agenda 2024-11-21.md new file mode 100644 index 00000000..fd479209 --- /dev/null +++ b/content/minutes/triage-meeting/T-compiler Meeting Agenda 2024-11-21.md @@ -0,0 +1,412 @@ +--- +tags: weekly, rustc +type: docs +note_id: AIoQaNMuSwOQ0UCkX38lZQ +--- + +# T-compiler Meeting Agenda 2024-11-21 + +## Announcements + +- Next week stable 1.83 is out :loudspeaker: +- Reminder: if you see a PR/issue that seems like there might be legal implications due to copyright/IP/etc, please let us know (or at least message @_**davidtwco** or @_**Wesley Wiser** so we can pass it along). + +### Other WG meetings + +- WG-async Design Meeting +- Types Team: ITE (Impl Trait Everywhere) Triage +- Stable MIR Weekly Meeting +- @_**davidtwco** office hours + +## MCPs/FCPs + +- New MCPs (take a look, see if you like them!) + - No new proposals this time. +- Old MCPs (stale MCP might be closed as per [MCP procedure](https://forge.rust-lang.org/compiler/mcp.html#when-should-major-change-proposals-be-closed)) + - None at this time +- Old MCPs (not seconded, take a look) + - "Add hygiene attributes to compile expanded source code" [compiler-team#692](https://github.com/rust-lang/compiler-team/issues/692) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Add.20option.20to.20compile.20expanded.20ASTs.20for.20h.E2.80.A6.20compiler-team.23692)) (last review activity: 2 months ago) + - "Add Hotpatch flag" [compiler-team#745](https://github.com/rust-lang/compiler-team/issues/745) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Add.20Hotpatch.20flag.20compiler-team.23745)) (last review activity: about 40 days ago) + - "Add `evex512` target feature for AVX10" [compiler-team#778](https://github.com/rust-lang/compiler-team/issues/778) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Add.20.60evex512.60.20target.20feature.20for.20AVX10.20compiler-team.23778)) (last review activity: 2 months ago) + - "Make the test cfg a userspace check-cfg" [compiler-team#785](https://github.com/rust-lang/compiler-team/issues/785) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Make.20the.20test.20cfg.20a.20userspace.20check-cfg.20compiler-team.23785)) (last review activity: about 0 days ago) + - "Policy change around adding new unstable flags" [compiler-team#787](https://github.com/rust-lang/compiler-team/issues/787) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Policy.20change.20around.20adding.20new.20unstable.20.E2.80.A6.20compiler-team.23787)) (last review activity: about 33 days ago) + - "Normalize FileCheck directives" [compiler-team#789](https://github.com/rust-lang/compiler-team/issues/789) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Normalize.20FileCheck.20directives.20compiler-team.23789)) (last review activity: about 33 days ago) + - "Relink, don't rebuild" [compiler-team#790](https://github.com/rust-lang/compiler-team/issues/790) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Relink.2C.20don.27t.20rebuild.20compiler-team.23790)) (last review activity: about 33 days ago) + - "Create an avr-unknown-none target" [compiler-team#800](https://github.com/rust-lang/compiler-team/issues/800) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Create.20an.20avr-unknown-unknown.20target.20compiler-team.23800)) (last review activity: about 11 days ago) + - "Unstable flag to choose Emscripten unwinding abi" [compiler-team#801](https://github.com/rust-lang/compiler-team/issues/801) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Unstable.20flag.20to.20choose.20Emscripten.20unwind.E2.80.A6.20compiler-team.23801)) (last review activity: about 5 days ago) +- Pending FCP requests (check your boxes!) + - "sanitizers: Stabilize AddressSanitizer and LeakSanitizer for the Tier 1 targets" [rust#123617](https://github.com/rust-lang/rust/pull/123617) + - "Lint on combining `#[no_mangle]` and `#[export_name]`" [rust#131558](https://github.com/rust-lang/rust/pull/131558) +- Things in FCP (make sure you're good with it) + - "Support for a new `wasm32-wali-linux-musl` Tier-3 target" [compiler-team#797](https://github.com/rust-lang/compiler-team/issues/797) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Support.20for.20a.20new.20.60wasm32-linux-musl.60.20Tie.E2.80.A6.20compiler-team.23797)) + - "Allow users to specify the TLS dialect (Traditional TLS vs. TLSDESC)" [compiler-team#805](https://github.com/rust-lang/compiler-team/issues/805) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Allow.20users.20to.20specify.20the.20TLS.20dialect.20.28T.E2.80.A6.20compiler-team.23805)) + - "New Tier-3 target proposal: `loongarch64-linux-android`" [compiler-team#806](https://github.com/rust-lang/compiler-team/issues/806) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/New.20Tier-3.20target.20proposal.3A.20.60loongarch64-.E2.80.A6.20compiler-team.23806)) + - "Ban field-projecting into `[rustc_layout_scalar_valid_range_*]` types" [compiler-team#807](https://github.com/rust-lang/compiler-team/issues/807) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Ban.20field-projecting.20into.20.60.5Brustc_layout_.E2.80.A6.20compiler-team.23807)) + - "Forbid disabling SSE on x86 targets that have SSE in their "baseline"" [compiler-team#808](https://github.com/rust-lang/compiler-team/issues/808) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Forbid.20disabling.20SSE.20on.20x86.20targets.20that.20.E2.80.A6.20compiler-team.23808)) + - "Also enable ICE file dumps on stable" [compiler-team#809](https://github.com/rust-lang/compiler-team/issues/809) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Also.20enable.20ICE.20file.20dumps.20on.20stable.20compiler-team.23809)) +- Accepted MCPs + - "Promote powerpc64le-unknown-linux-musl to tier 2" [compiler-team#803](https://github.com/rust-lang/compiler-team/issues/803) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Promote.20powerpc64le-unknown-linux-musl.20to.E2.80.A6.20compiler-team.23803)) +- MCPs blocked on unresolved concerns + - "Retire the mailing list and make all decisions on zulip" [compiler-team#649](https://github.com/rust-lang/compiler-team/issues/649) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Retire.20the.20mailing.20list.20and.20make.20all.20deci.E2.80.A6.20compiler-team.23649)) + - concern: [automatic-sync](https://github.com/rust-lang/compiler-team/issues/649#issuecomment-1618902660) +- Finalized FCPs (disposition merge) + - "Add `--print host-tuple` to print host target tuple" [rust#125579](https://github.com/rust-lang/rust/pull/125579) + - "Fix ICE when passing DefId-creating args to legacy_const_generics." [rust#130443](https://github.com/rust-lang/rust/pull/130443) + - "Stabilize WebAssembly `multivalue`, `reference-types`, and `tail-call` target features" [rust#131080](https://github.com/rust-lang/rust/pull/131080) + - "make unsupported_calling_conventions a hard error" [rust#129935](https://github.com/rust-lang/rust/pull/129935) +- Other teams finalized FCPs + - "Allow dropping `dyn Trait` principal" [rust#126660](https://github.com/rust-lang/rust/pull/126660) + - "Check elaborated projections from dyn don't mention unconstrained late bound lifetimes" [rust#130367](https://github.com/rust-lang/rust/pull/130367) + - "Do not consider match/let/ref of place that evaluates to `!` to diverge, disallow coercions from them too" [rust#129392](https://github.com/rust-lang/rust/pull/129392) + - "Finish stabilization of `result_ffi_guarantees`" [rust#130628](https://github.com/rust-lang/rust/pull/130628) + - "Fixup Windows verbatim paths when used with the `include!` macro" [rust#125205](https://github.com/rust-lang/rust/pull/125205) + - "Lint against getting pointers from immediately dropped temporaries" [rust#128985](https://github.com/rust-lang/rust/pull/128985) + - "Make deprecated_cfg_attr_crate_type_name a hard error" [rust#129670](https://github.com/rust-lang/rust/pull/129670) + - "Stabilize Arm64EC inline assembly" [rust#131781](https://github.com/rust-lang/rust/pull/131781) + - "Stabilize const `ptr::write*` and `mem::replace`" [rust#130954](https://github.com/rust-lang/rust/pull/130954) + - "Stabilize expr_2021 fragment specifier in all editions" [rust#129972](https://github.com/rust-lang/rust/pull/129972) + - "Stabilize s390x inline assembly" [rust#131258](https://github.com/rust-lang/rust/pull/131258) + - "Tracking issue for `const_size_of_val` and `const_align_of_val`" [rust#46571](https://github.com/rust-lang/rust/issues/46571) + - "atomics: allow atomic and non-atomic reads to race" [rust#128778](https://github.com/rust-lang/rust/pull/128778) + - "mark is_val_statically_known intrinsic as stably const-callable" [rust#132449](https://github.com/rust-lang/rust/pull/132449) + +## Backport nominations + +[T-compiler beta](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Abeta-nominated+-label%3Abeta-accepted+label%3AT-compiler) / [T-compiler stable](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Astable-nominated+-label%3Astable-accepted+label%3AT-compiler) +- :beta: "Enforce that raw lifetimes must be valid raw identifiers" [rust#132363](https://github.com/rust-lang/rust/pull/132363) + - Authored and nominated by compiler-errors + - Fix something we noticed (not an issue reported) see [comment](https://github.com/rust-lang/reference/pull/1603#discussion_r1822726753) + - Patch sibling to #132341 (work on #126452), approved for backport + - FCP'd by t-lang, also in favor of a backport ([comment](https://github.com/rust-lang/rust/pull/132363#issuecomment-2487363849)) + +- :beta: "Add discriminators to DILocations when multiple functions are inlined into a single point." [rust#132613](https://github.com/rust-lang/rust/pull/132613) + - Authored by khuey + - we postponed the vote last week ([comment](https://github.com/rust-lang/rust/pull/132613#issuecomment-2476684329)) because we wanted to see how #132900 was (or wasn't) related + - So, yes, it was related ([here](https://github.com/rust-lang/rust/pull/133194#issue-2670635621) more context) but #132900 is solved by a follow-up patch from @**cuviper** in #133194 + +- :beta: "Update cdb annotations for some debuginfo tests with cdb `10.0.26100.2161`" [rust#133115](https://github.com/rust-lang/rust/pull/133115) + - Authored by jieyouxu + - Fixes some tests on windows target, CI image was updated CDB (MS debugger) + - nominated by @_**cuviper** because this is probably affecting beta+stable 1.83 ([comment](https://github.com/rust-lang/rust/pull/133115#issuecomment-2480812972)) + +- :beta: "Drop debug info instead of panicking if we exceed LLVM's capability to represent it" [rust#133194](https://github.com/rust-lang/rust/pull/133194) + - Authored by khuey + - Fixes an ICE #132900 + - makes sense a backport of both this and #132613 (or neither, see [comment](https://github.com/rust-lang/rust/pull/133194#issuecomment-2486609480)) + +- No stable nominations for `T-compiler` this time. + +[T-types stable](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Abeta-nominated+-label%3Abeta-accepted+label%3AT-types) / [T-types beta](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Astable-nominated+-label%3Astable-accepted+label%3AT-types) +- No beta nominations for `T-types` this time. +- No stable nominations for `T-types` this time. + +## PRs S-waiting-on-team + +[T-compiler](https://github.com/rust-lang/rust/pulls?q=is%3Aopen+label%3AS-waiting-on-team+label%3AT-compiler) +- [Issues in progress or waiting on other teams](https://hackmd.io/XYr1BrOWSiqCrl8RCWXRaQ) + +## Issues of Note + +### Short Summary + +- [0 T-compiler P-critical issues](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-compiler+label%3AP-critical) + - [0 of those are unassigned](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-compiler+label%3AP-critical+no%3Aassignee) +- [65 T-compiler P-high issues](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-compiler+label%3AP-high) + - [41 of those are unassigned](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-compiler+label%3AP-high+no%3Aassignee) +- [0 P-critical, 0 P-high, 2 P-medium, 1 P-low regression-from-stable-to-beta](https://github.com/rust-lang/rust/labels/regression-from-stable-to-beta) +- [0 P-critical, 1 P-high, 5 P-medium, 2 P-low regression-from-stable-to-nightly](https://github.com/rust-lang/rust/labels/regression-from-stable-to-nightly) +- [0 P-critical, 36 P-high, 100 P-medium, 17 P-low regression-from-stable-to-stable](https://github.com/rust-lang/rust/labels/regression-from-stable-to-stable) + +### P-critical + +[T-compiler](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AP-critical+label%3AT-compiler) +- No `P-critical` issues for `T-compiler` this time. + +[T-types](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AP-critical+label%3AT-types) +- No `P-critical` issues for `T-types` this time. + +### P-high regressions + +[P-high beta regressions](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3Aregression-from-stable-to-beta+label%3AP-high+-label%3AT-infra+-label%3AT-libs+-label%3AT-libs-api+-label%3AT-release+-label%3AT-rustdoc+-label%3AT-core) +- No `P-high` beta regressions this time. + +[Unassigned P-high nightly regressions](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3Aregression-from-stable-to-nightly+label%3AP-high+no%3Aassignee+-label%3AT-infra+-label%3AT-libs+-label%3AT-libs-api+-label%3AT-release+-label%3AT-rustdoc+-label%3AT-core+) +- "error: the compiler unexpectedly panicked. this is a bug." [rust#132920](https://github.com/rust-lang/rust/issues/132920) + - we have a [smaller repro](https://github.com/rust-lang/rust/issues/132920#issuecomment-2470552757) + - seems originated in #128849 ([comment](https://github.com/rust-lang/rust/issues/132920#issuecomment-2469191911)) + - P-high because the ICE completely shadows the error (but we can lower the priority) + +## Performance logs + +> [triage logs 2024-11-19](https://github.com/rust-lang/rustc-perf/blob/master/triage/2024-11-19.md) + +We saw improvements to a large swath of benchmarks with the querification of +MonoItem collection (PR #132566). There were also some PRs where we are willing +to pay a compile-time cost for expected runtime benefit (PR #132870, PR #120370), +or pay a small cost in the single-threaded case in exchange for a big parallel +compilation win (PR #124780). + +Triage done by **@pnkfelix**. +Revision range: [d4822c2d..7d40450b](https://perf.rust-lang.org/?start=d4822c2d84c242cc7403118b50c571464f38ef8f&end=7d40450b2df92bdc9dec414b30cf5f7a5979a92e&absolute=false&stat=instructions%3Au) + +**Summary**: + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:---------------:|:-----:| +| Regressions (primary) | 1.1% | [0.2%, 7.3%] | 195 | +| Regressions (secondary) | 1.3% | [0.1%, 5.0%] | 194 | +| Improvements (primary) | -7.3% | [-24.9%, -0.3%] | 60 | +| Improvements (secondary) | -9.4% | [-67.0%, -0.3%] | 23 | +| All (primary) | -0.9% | [-24.9%, 7.3%] | 255 | + + +2 Regressions, 4 Improvements, 10 Mixed; 6 of them in rollups +47 artifact comparisons made in total +30 untriaged PRs + +#### Regressions + +Rollup of 5 pull requests [#133039](https://github.com/rust-lang/rust/pull/133039) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c82e0dff84f922274c3060f09b5ae78d5dbf5c49&end=90ab8eaedd3efd7919bffa7638db66e67df3f0b8&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:----:|:------------:|:-----:| +| Regressions (primary) | 0.3% | [0.3%, 0.3%] | 1 | +| Regressions (secondary) | 0.3% | [0.2%, 0.4%] | 13 | +| Improvements (primary) | - | - | 0 | +| Improvements (secondary) | - | - | 0 | +| All (primary) | 0.3% | [0.3%, 0.3%] | 1 | + +* sole primary regression is to doc (full) on helloworld. +* already triaged as being due to PR #133005 (and categorized as "improvements to rustdoc search that justify this cost") + +Rollup of 7 pull requests [#133120](https://github.com/rust-lang/rust/pull/133120) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ee4a56e353dc3ddfcb12df5fe2dc1329a315c2f5&end=1e0df74445a185fc97b7e806cd6c636eaded1326&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:----:|:------------:|:-----:| +| Regressions (primary) | 0.2% | [0.1%, 0.3%] | 25 | +| Regressions (secondary) | 0.2% | [0.1%, 0.4%] | 14 | +| Improvements (primary) | - | - | 0 | +| Improvements (secondary) | - | - | 0 | +| All (primary) | 0.2% | [0.1%, 0.3%] | 25 | + +* primary regressions to {serde, libc, diesel, cargo, cranelift-codegen} (across multiple scenarios) and {html5ever, ripgrep, exa, syn, stm32f4, image, regex, webrender, hyper} (in isolated scenarios). +* @nnethercote has hypothesized that PR #132134 may be responsible and is planning to investigate. +* Not marking as triaged. + +#### Improvements + +move all mono-time checks into their own folder, and their own query [#132843](https://github.com/rust-lang/rust/pull/132843) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5700240affd222f69b8755e2ff5d4ccaae9e6cf9&end=583b25d8d1bf934f593d9d9811f88305888032b5&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | - | - | 0 | +| Regressions (secondary) | - | - | 0 | +| Improvements (primary) | -0.2% | [-0.2%, -0.2%] | 4 | +| Improvements (secondary) | -0.4% | [-0.4%, -0.4%] | 1 | +| All (primary) | -0.2% | [-0.2%, -0.2%] | 4 | + +* (based on conversation in the PR itself, I think this "gain" is illusory and these benchmarks are just unstable) + +Rollup of 4 pull requests [#133047](https://github.com/rust-lang/rust/pull/133047) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=90ab8eaedd3efd7919bffa7638db66e67df3f0b8&end=e84902d35a4d3039c794e139eb12fba3624c5ff1&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | - | - | 0 | +| Regressions (secondary) | - | - | 0 | +| Improvements (primary) | -0.2% | [-0.4%, -0.0%] | 2 | +| Improvements (secondary) | -0.2% | [-0.4%, -0.1%] | 4 | +| All (primary) | -0.2% | [-0.4%, -0.0%] | 2 | + + +Rollup of 5 pull requests [#133086](https://github.com/rust-lang/rust/pull/133086) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=917a50a03931a9861c19a46f3e2a02a28f1da936&end=d3a4b1f46ba0fff6239e3d75abd285287ccd17f9&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | - | - | 0 | +| Regressions (secondary) | - | - | 0 | +| Improvements (primary) | - | - | 0 | +| Improvements (secondary) | -4.2% | [-4.2%, -4.2%] | 1 | +| All (primary) | - | - | 0 | + + +Rollup of 5 pull requests [#133179](https://github.com/rust-lang/rust/pull/133179) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c602e9aeaab636302d52b17da64e84044462a230&end=03ee4845197ce71aa5ee28cb937a3e863b18b42f&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | - | - | 0 | +| Regressions (secondary) | - | - | 0 | +| Improvements (primary) | -0.1% | [-0.2%, -0.1%] | 3 | +| Improvements (secondary) | -0.3% | [-0.4%, -0.2%] | 2 | +| All (primary) | -0.1% | [-0.2%, -0.1%] | 3 | + + +#### Mixed + +Rollup of 7 pull requests [#132919](https://github.com/rust-lang/rust/pull/132919) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=81eef2d362a6f03db6f8928f82d94298d31eb81b&end=67f21277cd40cd12e69aa34089f4a20926fd6dc5&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 0.4% | [0.1%, 1.3%] | 6 | +| Regressions (secondary) | 0.2% | [0.1%, 0.2%] | 2 | +| Improvements (primary) | -0.1% | [-0.1%, -0.1%] | 1 | +| Improvements (secondary) | -2.4% | [-2.4%, -2.4%] | 1 | +| All (primary) | 0.3% | [-0.1%, 1.3%] | 7 | + +* primary regressions are to doc scenarios; further investigation has indicated that PR #132144 is the root cause of them. +* pnkfelix's understanding is that this is known potential cost of progress when adding new traits (Receiver in this case) to stdlib. +* marked as triaged + +`#[inline]` integer parsing functions [#132870](https://github.com/rust-lang/rust/pull/132870) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f7273e0044ad8f35ad27282e4ab776af50b61a54&end=b420d923cff05f51eb43f607f5d8dce827eeba97&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 0.9% | [0.1%, 5.1%] | 12 | +| Regressions (secondary) | 1.0% | [0.4%, 2.3%] | 9 | +| Improvements (primary) | -0.4% | [-0.6%, -0.2%] | 3 | +| Improvements (secondary) | - | - | 0 | +| All (primary) | 0.6% | [-0.6%, 5.1%] | 15 | + +* main notable regressions were to regex opt-incr-patched (5%), cargo opt-full (1.14%), cranelift-codegen opt-full (0.83%) and ripgrep opt-full (0.74%); (everything else was <0.5% change). +* this is incurring a compilation cost, especially on opt builds, because its inlining more stuff +* pnkfelix assumes that the runtime benefit justifies this runtime cost. +* marking as triaged + +[perf] rustdoc: Perform less work when cleaning middle::ty parenthesized generic args [#132886](https://github.com/rust-lang/rust/pull/132886) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=44f233f2519ce5d633c87c38014d03d8a5f0e810&end=ec239b888f3945a6ce043db639f1741d14f08874&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 1.0% | [1.0%, 1.0%] | 2 | +| Regressions (secondary) | 0.2% | [0.2%, 0.2%] | 1 | +| Improvements (primary) | - | - | 0 | +| Improvements (secondary) | -0.2% | [-0.3%, -0.1%] | 5 | +| All (primary) | 1.0% | [1.0%, 1.0%] | 2 | + +* already identified as measurement bias/noise and marked as triaged; thanks lqd! + +Reland #132772: use `download-rustc="if-unchanged"` as a global default [#132872](https://github.com/rust-lang/rust/pull/132872) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ec239b888f3945a6ce043db639f1741d14f08874&end=65b3877488ccfef3b1a903bfdd269559c59b957c&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | - | - | 0 | +| Regressions (secondary) | 0.2% | [0.2%, 0.3%] | 2 | +| Improvements (primary) | -1.1% | [-1.1%, -1.0%] | 3 | +| Improvements (secondary) | -0.5% | [-0.9%, -0.3%] | 6 | +| All (primary) | -1.1% | [-1.1%, -1.0%] | 3 | + +* already identified as measurement bias/noise and marked as triaged; thanks lqd! + +tweak attributes for const panic macro [#132662](https://github.com/rust-lang/rust/pull/132662) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a00df61387e5389d6fe23e38e657f90d672668b1&end=8adb4b30f40e6fbd21dc1ba26c3301c7eeb6de3c&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 0.7% | [0.5%, 0.9%] | 2 | +| Regressions (secondary) | - | - | 0 | +| Improvements (primary) | -0.7% | [-2.0%, -0.2%] | 6 | +| Improvements (secondary) | - | - | 0 | +| All (primary) | -0.3% | [-2.0%, 0.9%] | 8 | + +* primary regressions are to image (0.92%) and webrender (0.50%) in opt-full scenarios. +* it seems like this might be just noise from changes to inlining decisions, since it seems like both those cases are undoing artificial improvements introduced by PR #132870 (noted above) +* marking as triaged + +rustc_metadata: Preprocess search paths for better performance [#132910](https://github.com/rust-lang/rust/pull/132910) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f00f68245ebe85960000adaab18c1fe8da104cfe&end=76fd47124b8f8037b6187169b2cdf39139466952&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 0.0% | [0.0%, 0.0%] | 1 | +| Regressions (secondary) | 2.2% | [0.1%, 4.4%] | 2 | +| Improvements (primary) | - | - | 0 | +| Improvements (secondary) | -0.2% | [-0.2%, -0.2%] | 2 | +| All (primary) | 0.0% | [0.0%, 0.0%] | 1 | + +* already marked by saethlin as triaged: "The reported regressions are extremely marginal, and the discussion above: [#132910 (comment)](https://github.com/rust-lang/rust/pull/132910#issuecomment-2473240290) contains instructions for how to demonstrate a quite significant benefit of this change." + +Querify MonoItem collection [#132566](https://github.com/rust-lang/rust/pull/132566) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5afd5ad29c014de69bea61d028a1ce832ed75a75&end=ee4a56e353dc3ddfcb12df5fe2dc1329a315c2f5&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:---------------:|:-----:| +| Regressions (primary) | 1.7% | [0.3%, 6.6%] | 10 | +| Regressions (secondary) | 1.7% | [0.3%, 3.7%] | 23 | +| Improvements (primary) | -6.3% | [-25.1%, -0.1%] | 73 | +| Improvements (secondary) | -9.9% | [-67.2%, -0.3%] | 22 | +| All (primary) | -5.4% | [-25.1%, 6.6%] | 83 | + +* massive improvements; many incremental benchmarks are improved by 5% to 20% (and even 25% in the case of ripgrep) +* the regressions here (mostly to helloworld) were anticipated during review and are far outweighed by the very notable gains in compiler performance across a broad swath of benchmarks. +* marking as triaged + +Likely unlikely fix [#120370](https://github.com/rust-lang/rust/pull/120370) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5ec7d6eee7e0f5236ec1559499070eaf836bc608&end=3fb7e441aecc3c054d71eb4d752d06e7776e8888&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 0.9% | [0.1%, 2.8%] | 4 | +| Regressions (secondary) | 0.8% | [0.2%, 1.7%] | 18 | +| Improvements (primary) | -0.4% | [-1.9%, -0.1%] | 21 | +| Improvements (secondary) | -0.3% | [-0.4%, -0.1%] | 11 | +| All (primary) | -0.2% | [-1.9%, 2.8%] | 25 | + +* primary regressions on html5ever opt-full (2.78%), image opt-incr-patched (0.35%) (and stm32f4 doc-full (0.11%) but that's probably noise) +* already triaged by saethlin; "some change is expected because these intrinsics used to do nothing" (i.e. they were broken before and are now believed to be fixed). Also clearly the benefits on the primary benchmarks is outweighing the limited primary regressions. + +Use `TypingMode` throughout the compiler instead of `ParamEnv` [#132460](https://github.com/rust-lang/rust/pull/132460) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=03ee4845197ce71aa5ee28cb937a3e863b18b42f&end=b71fb5edc0217eaf8fc824a44cd7b0945e29ff4d&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 0.2% | [0.1%, 0.4%] | 8 | +| Regressions (secondary) | 0.9% | [0.2%, 2.7%] | 6 | +| Improvements (primary) | -0.3% | [-0.3%, -0.3%] | 1 | +| Improvements (secondary) | -0.8% | [-0.9%, -0.7%] | 5 | +| All (primary) | 0.1% | [-0.3%, 0.4%] | 9 | + +* primary regressions to unicode-normalization profiles and (to a lesser extent) diesel, stm32f4, and cargo. +* it seems like this regression was to some extent anticipated, at least from the [perf run that was done](https://github.com/rust-lang/rust/pull/132460#issuecomment-2465546736) while the PR was in development. +* not formally marking as triaged yet; instead, left note saying that I'm inclined to mark as triage if either the PR author or the PR reviewer agree that this "regression", such as it is, was anticipated. + +Improve VecCache under parallel frontend [#124780](https://github.com/rust-lang/rust/pull/124780) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b71fb5edc0217eaf8fc824a44cd7b0945e29ff4d&end=5926e82dd1eae211c6e2ffe446de54df04798e89&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:----------------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 1.0% | [0.2%, 3.3%] | 214 | +| Regressions (secondary) | 1.0% | [0.2%, 2.9%] | 172 | +| Improvements (primary) | - | - | 0 | +| Improvements (secondary) | -1.9% | [-3.0%, -0.4%] | 8 | +| All (primary) | 1.0% | [0.2%, 3.3%] | 214 | + +* left a note pointing out that there was a pretty serious process deviation, in that this was marked with rustc-perf-triaged for a different commit (maybe a different commit series?), months before this had gotten review or even landed... +* but having said that, I looked over the data and it seems like the label remains justified, so I have left the label in place. + +## Nominated Issues + +[T-compiler](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AI-compiler-nominated) +- "Renaming targets might be a breaking change" [rust#133030](https://github.com/rust-lang/rust/issues/133030) + - Nominated by ([comment](https://github.com/rust-lang/rust/issues/133030#issuecomment-2478320511)) + > Does T-compiler want to amend the target policy docs to better reflect what *compiler* stability guarantees are made and what is *explicitly* not covered by *compiler* stability guarantees, as opposed to *library API* stability guarantees and *language* stability guarantees. + - And: + > Are there any difference in stability guarantees (or the explicit lack thereof) for different-tiered compiler targets. + +[RFC](https://github.com/rust-lang/rfcs/issues?q=is%3Aopen+label%3AI-compiler-nominated) +- No I-compiler-nominated RFCs this time. + +### Oldest PRs waiting for review + +None this week + +Next meetings' agenda draft: [hackmd link](https://hackmd.io/y41E-EkQQW2kpkhEy5vTbA) diff --git a/content/minutes/triage-meeting/T-compiler Meeting Agenda 2024-11-28.md b/content/minutes/triage-meeting/T-compiler Meeting Agenda 2024-11-28.md new file mode 100644 index 00000000..c0028eb8 --- /dev/null +++ b/content/minutes/triage-meeting/T-compiler Meeting Agenda 2024-11-28.md @@ -0,0 +1,316 @@ +--- +tags: weekly, rustc +type: docs +note_id: AIqvziC1SXaPGsfLKO0u2g +--- + +# T-compiler Meeting Agenda 2024-11-28 + +## Announcements + +- Today, stable 1.83 is out! :tada: + - [1.83 release notes](https://github.com/cuviper/rust/blob/46cd0c526691f485365e57228c99db8f7c16c324/RELEASES.md) + - [1.83 blog post](https://github.com/BoxyUwU/blog.rust-lang.org/blob/1.83.0/posts/2024-11-28-Rust-1.83.0.md) +- Reminder: if you see a PR/issue that seems like there might be legal implications due to copyright/IP/etc, please let us know (or at least message @_**davidtwco** or @_**Wesley Wiser** so we can pass it along). + +### Other WG meetings + +- WG-async Design Meeting +- Types Team: ITE (Impl Trait Everywhere) Triage +- @_**davidtwco** office hours + +## MCPs/FCPs + +- New MCPs (take a look, see if you like them!) + - "Promote OpenHarmony targets to Tier 2 with Host Tools" [compiler-team#811](https://github.com/rust-lang/compiler-team/issues/811) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Promote.20OpenHarmony.20targets.20to.20Tier.202.20wit.E2.80.A6.20compiler-team.23811)) +- Old MCPs (stale MCP might be closed as per [MCP procedure](https://forge.rust-lang.org/compiler/mcp.html#when-should-major-change-proposals-be-closed)) + - None at this time +- Old MCPs (not seconded, take a look) + - "Add hygiene attributes to compile expanded source code" [compiler-team#692](https://github.com/rust-lang/compiler-team/issues/692) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Add.20option.20to.20compile.20expanded.20ASTs.20for.20h.E2.80.A6.20compiler-team.23692)) (last review activity: 2 months ago) + - "Add Hotpatch flag" [compiler-team#745](https://github.com/rust-lang/compiler-team/issues/745) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Add.20Hotpatch.20flag.20compiler-team.23745)) (last review activity: about 48 days ago) + - "Add `evex512` target feature for AVX10" [compiler-team#778](https://github.com/rust-lang/compiler-team/issues/778) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Add.20.60evex512.60.20target.20feature.20for.20AVX10.20compiler-team.23778)) (last review activity: 2 months ago) + - "Make the test cfg a userspace check-cfg" [compiler-team#785](https://github.com/rust-lang/compiler-team/issues/785) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Make.20the.20test.20cfg.20a.20userspace.20check-cfg.20compiler-team.23785)) (last review activity: about 8 days ago) + - "Policy change around adding new unstable flags" [compiler-team#787](https://github.com/rust-lang/compiler-team/issues/787) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Policy.20change.20around.20adding.20new.20unstable.20.E2.80.A6.20compiler-team.23787)) (last review activity: about 41 days ago) + - "Normalize FileCheck directives" [compiler-team#789](https://github.com/rust-lang/compiler-team/issues/789) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Normalize.20FileCheck.20directives.20compiler-team.23789)) (last review activity: about 41 days ago) + - "Relink, don't rebuild" [compiler-team#790](https://github.com/rust-lang/compiler-team/issues/790) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Relink.2C.20don.27t.20rebuild.20compiler-team.23790)) (last review activity: about 41 days ago) + - "Create an avr-unknown-none target" [compiler-team#800](https://github.com/rust-lang/compiler-team/issues/800) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Create.20an.20avr-unknown-unknown.20target.20compiler-team.23800)) (last review activity: about 19 days ago) +- Pending FCP requests (check your boxes!) + - "sanitizers: Stabilize AddressSanitizer and LeakSanitizer for the Tier 1 targets" [rust#123617](https://github.com/rust-lang/rust/pull/123617) +- Things in FCP (make sure you're good with it) + - "Unstable flag to choose Emscripten unwinding abi" [compiler-team#801](https://github.com/rust-lang/compiler-team/issues/801) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Unstable.20flag.20to.20choose.20Emscripten.20unwind.E2.80.A6.20compiler-team.23801)) + - "Delete current polymorphization implementation" [compiler-team#810](https://github.com/rust-lang/compiler-team/issues/810) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Delete.20current.20polymorphization.20implement.E2.80.A6.20compiler-team.23810)) + - "Lint on combining `#[no_mangle]` and `#[export_name]`" [rust#131558](https://github.com/rust-lang/rust/pull/131558) +- Accepted MCPs + - "Support for a new `wasm32-wali-linux-musl` Tier-3 target" [compiler-team#797](https://github.com/rust-lang/compiler-team/issues/797) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Support.20for.20a.20new.20.60wasm32-linux-musl.60.20Tie.E2.80.A6.20compiler-team.23797)) + - "Promote powerpc64le-unknown-linux-musl to tier 2" [compiler-team#803](https://github.com/rust-lang/compiler-team/issues/803) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Promote.20powerpc64le-unknown-linux-musl.20to.E2.80.A6.20compiler-team.23803)) + - "Allow users to specify the TLS dialect (Traditional TLS vs. TLSDESC)" [compiler-team#805](https://github.com/rust-lang/compiler-team/issues/805) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Allow.20users.20to.20specify.20the.20TLS.20dialect.20.28T.E2.80.A6.20compiler-team.23805)) + - "Ban field-projecting into `[rustc_layout_scalar_valid_range_*]` types" [compiler-team#807](https://github.com/rust-lang/compiler-team/issues/807) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Ban.20field-projecting.20into.20.60.5Brustc_layout_.E2.80.A6.20compiler-team.23807)) + - "Forbid disabling SSE on x86 targets that have SSE in their "baseline"" [compiler-team#808](https://github.com/rust-lang/compiler-team/issues/808) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Forbid.20disabling.20SSE.20on.20x86.20targets.20that.20.E2.80.A6.20compiler-team.23808)) +- MCPs blocked on unresolved concerns + - "New Tier-3 target proposal: `loongarch64-linux-android`" [compiler-team#806](https://github.com/rust-lang/compiler-team/issues/806) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/New.20Tier-3.20target.20proposal.3A.20.60loongarch64-.E2.80.A6.20compiler-team.23806)) + - concern: [unsupported-architecture](https://github.com/rust-lang/compiler-team/issues/806#issuecomment-2489820226) + - "Retire the mailing list and make all decisions on zulip" [compiler-team#649](https://github.com/rust-lang/compiler-team/issues/649) ([Zulip](https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Retire.20the.20mailing.20list.20and.20make.20all.20deci.E2.80.A6.20compiler-team.23649)) + - concern: [automatic-sync](https://github.com/rust-lang/compiler-team/issues/649#issuecomment-1618902660) +- Finalized FCPs (disposition merge) + - "Add `--print host-tuple` to print host target tuple" [rust#125579](https://github.com/rust-lang/rust/pull/125579) + - "make unsupported_calling_conventions a hard error" [rust#129935](https://github.com/rust-lang/rust/pull/129935) + - "Fix ICE when passing DefId-creating args to legacy_const_generics." [rust#130443](https://github.com/rust-lang/rust/pull/130443) + - "Stabilize WebAssembly `multivalue`, `reference-types`, and `tail-call` target features" [rust#131080](https://github.com/rust-lang/rust/pull/131080) +- Other teams finalized FCPs + - "Fixup Windows verbatim paths when used with the `include!` macro" [rust#125205](https://github.com/rust-lang/rust/pull/125205) + - "Allow dropping `dyn Trait` principal" [rust#126660](https://github.com/rust-lang/rust/pull/126660) + - "atomics: allow atomic and non-atomic reads to race" [rust#128778](https://github.com/rust-lang/rust/pull/128778) + - "Lint against getting pointers from immediately dropped temporaries" [rust#128985](https://github.com/rust-lang/rust/pull/128985) + - "Do not consider match/let/ref of place that evaluates to `!` to diverge, disallow coercions from them too" [rust#129392](https://github.com/rust-lang/rust/pull/129392) + - "Make deprecated_cfg_attr_crate_type_name a hard error" [rust#129670](https://github.com/rust-lang/rust/pull/129670) + - "Stabilize expr_2021 fragment specifier in all editions" [rust#129972](https://github.com/rust-lang/rust/pull/129972) + - "Check elaborated projections from dyn don't mention unconstrained late bound lifetimes" [rust#130367](https://github.com/rust-lang/rust/pull/130367) + - "Finish stabilization of `result_ffi_guarantees`" [rust#130628](https://github.com/rust-lang/rust/pull/130628) + - "Stabilize const `ptr::write*` and `mem::replace`" [rust#130954](https://github.com/rust-lang/rust/pull/130954) + - "Stabilize s390x inline assembly" [rust#131258](https://github.com/rust-lang/rust/pull/131258) + - "Stabilize Arm64EC inline assembly" [rust#131781](https://github.com/rust-lang/rust/pull/131781) + - "mark is_val_statically_known intrinsic as stably const-callable" [rust#132449](https://github.com/rust-lang/rust/pull/132449) + +## Backport nominations + +[T-compiler beta](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Abeta-nominated+-label%3Abeta-accepted+label%3AT-compiler) / [T-compiler stable](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Astable-nominated+-label%3Astable-accepted+label%3AT-compiler) +- :beta:"[AIX] Add option -X32_64 to the "strip" command" [rust#133217](https://github.com/rust-lang/rust/pull/133217) + - Authored by xingxue-ibm + - Nominated by contributor mustartt + - This fixes a lot of test cases on AIX and allows the strip to function properly without OBJECT_MODE=64 ([comment](https://github.com/rust-lang/rust/pull/133217#issuecomment-2499520684)) + +- :beta:"Use ReadCache for archive reading in bootstrap" [rust#133462](https://github.com/rust-lang/rust/pull/133462) + - Authored and nominated by mustartt + - Fixes #133268, some AIX specific issues + - Speeds up the boostrap for 1.84 builds and fixes small build error ([comment](https://github.com/rust-lang/rust/pull/133462#issuecomment-2501802541)) + +- No stable nominations for `T-compiler` this time. + +[T-types stable](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Abeta-nominated+-label%3Abeta-accepted+label%3AT-types) / [T-types beta](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Astable-nominated+-label%3Astable-accepted+label%3AT-types) +- No beta nominations for `T-types` this time. +- No stable nominations for `T-types` this time. + +## PRs S-waiting-on-team + +[T-compiler](https://github.com/rust-lang/rust/pulls?q=is%3Aopen+label%3AS-waiting-on-team+label%3AT-compiler) +- "Add a tidy rule forbidding modules named `build`" [rust#133404](https://github.com/rust-lang/rust/pull/133404) + - FIY for T-compiler, discussion in progress [on Zulip](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/The.20.60build.2F.60.20ignore.20rule) +- [Issues in progress or waiting on other teams](https://hackmd.io/XYr1BrOWSiqCrl8RCWXRaQ) + +## Issues of Note + +### Short Summary + +- [0 T-compiler P-critical issues](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-compiler+label%3AP-critical) + - [0 of those are unassigned](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-compiler+label%3AP-critical+no%3Aassignee) +- [59 T-compiler P-high issues](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-compiler+label%3AP-high) + - [39 of those are unassigned](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AT-compiler+label%3AP-high+no%3Aassignee) +- [0 P-critical, 0 P-high, 1 P-medium, 0 P-low regression-from-stable-to-beta](https://github.com/rust-lang/rust/labels/regression-from-stable-to-beta) +- [0 P-critical, 0 P-high, 5 P-medium, 2 P-low regression-from-stable-to-nightly](https://github.com/rust-lang/rust/labels/regression-from-stable-to-nightly) +- [0 P-critical, 33 P-high, 100 P-medium, 17 P-low regression-from-stable-to-stable](https://github.com/rust-lang/rust/labels/regression-from-stable-to-stable) + +### P-critical + +[T-compiler](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AP-critical+label%3AT-compiler) +- No `P-critical` issues for `T-compiler` this time. + +[T-types](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AP-critical+label%3AT-types) +- No `P-critical` issues for `T-types` this time. + +### P-high regressions + +[P-high beta regressions](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3Aregression-from-stable-to-beta+label%3AP-high+-label%3AT-infra+-label%3AT-libs+-label%3AT-libs-api+-label%3AT-release+-label%3AT-rustdoc+-label%3AT-core) +- No `P-high` beta regressions this time. + +[Unassigned P-high nightly regressions](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3Aregression-from-stable-to-nightly+label%3AP-high+no%3Aassignee+-label%3AT-infra+-label%3AT-libs+-label%3AT-libs-api+-label%3AT-release+-label%3AT-rustdoc+-label%3AT-core+) +- None + +## Performance logs + +> [triage logs for 2024-11-26](https://github.com/Kobzol/rustc-perf/blob/556db980efa8c8553fe92ce64f04db372b0c7d61/triage/2024-11-26.md) + +This week saw more regressions than improvements, mostly due to three PRs that performed internal +refactorings that are necessary for further development and modification of the compiler. + +Triage done by **@kobzol**. +Revision range: [7d40450b..7db7489f](https://perf.rust-lang.org/?start=7d40450b2df92bdc9dec414b30cf5f7a5979a92e&end=7db7489f9bc274cb60c4956bfa56de0185eb1b9b&absolute=false&stat=instructions%3Au) + +**Summary**: + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 0.6% | [0.1%, 3.6%] | 57 | +| Regressions (secondary) | 0.6% | [0.0%, 2.7%] | 100 | +| Improvements (primary) | -0.5% | [-1.5%, -0.2%] | 11 | +| Improvements (secondary) | -0.4% | [-0.5%, -0.3%] | 7 | +| All (primary) | 0.4% | [-1.5%, 3.6%] | 68 | + + +4 Regressions, 2 Improvements, 3 Mixed; 3 of them in rollups +40 artifact comparisons made in total + +#### Regressions + +Rollup of 8 pull requests [#133219](https://github.com/rust-lang/rust/pull/133219) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ee612c45f00391aff71ec0c52b7fc08fae18c711&end=875df370be806c837f58abb638329905e969ace4&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:----:|:------------:|:-----:| +| Regressions (primary) | 0.7% | [0.2%, 1.1%] | 6 | +| Regressions (secondary) | 0.5% | [0.3%, 1.2%] | 13 | +| Improvements (primary) | - | - | 0 | +| Improvements (secondary) | - | - | 0 | +| All (primary) | 0.7% | [0.2%, 1.1%] | 6 | + +- The regressions were on the helloworld benchmark and other tiny crates, and they were reverted +in a follow-up merge commit. +- Marked as triaged. + +continue `ParamEnv` to `TypingEnv` transition [#133212](https://github.com/rust-lang/rust/pull/133212) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=bcfea1f8d253fd43eab36832fa601d192ac603d5&end=70e814bd9e532a302763f870c665c5af59c2b632&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:----:|:------------:|:-----:| +| Regressions (primary) | 0.4% | [0.3%, 0.5%] | 5 | +| Regressions (secondary) | 2.1% | [0.1%, 6.6%] | 12 | +| Improvements (primary) | - | - | 0 | +| Improvements (secondary) | - | - | 0 | +| All (primary) | 0.4% | [0.3%, 0.5%] | 5 | + +- Regressions caused by internal refactoring of the type system that is necessary for further +improvements. +- Asked the PR author about the perf. effect of this PR and also +of [#133242](https://github.com/rust-lang/rust/pull/133242) (mentioned below). +- Not marking as triaged. + +Rollup of 5 pull requests [#133280](https://github.com/rust-lang/rust/pull/133280) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=318f96a8cf3eca5c4aaf60a992f349bce5c3fd41&end=0b1bf71a71c2a1d34c212285362530ec2c4e4775&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:----:|:------------:|:-----:| +| Regressions (primary) | 0.3% | [0.2%, 0.4%] | 7 | +| Regressions (secondary) | 2.0% | [2.0%, 2.0%] | 1 | +| Improvements (primary) | - | - | 0 | +| Improvements (secondary) | - | - | 0 | +| All (primary) | 0.3% | [0.2%, 0.4%] | 7 | + +- The secondary regression is noise. +- The primary regressions look to be genuine, but they are only on a single benchmark and they are +very small, so I don't think that further investigation is needed. +- Marked as triaged. + +finish `Reveal` removal [#133242](https://github.com/rust-lang/rust/pull/133242) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=826b673412d2f579e7865b6f26bc9771c6d3b097&end=386a7c7ae22a3727c6a06633212d5a95edabdd74&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:----:|:------------:|:-----:| +| Regressions (primary) | 0.7% | [0.2%, 3.6%] | 11 | +| Regressions (secondary) | 0.3% | [0.2%, 0.4%] | 24 | +| Improvements (primary) | - | - | 0 | +| Improvements (secondary) | - | - | 0 | +| All (primary) | 0.7% | [0.2%, 3.6%] | 11 | + +- Similar situation as in [#133212](https://github.com/rust-lang/rust/pull/133212). +- Not marking as triaged. + +#### Improvements + +Resolve tweaks [#132761](https://github.com/rust-lang/rust/pull/132761) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=78993684f2ba22082197d63627f3e91069911839&end=ee612c45f00391aff71ec0c52b7fc08fae18c711&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | - | - | 0 | +| Regressions (secondary) | - | - | 0 | +| Improvements (primary) | -0.3% | [-0.6%, -0.1%] | 68 | +| Improvements (secondary) | -1.1% | [-1.1%, -1.1%] | 1 | +| All (primary) | -0.3% | [-0.6%, -0.1%] | 68 | + + +Drop debug info instead of panicking if we exceed LLVM's capability to represent it [#133194](https://github.com/rust-lang/rust/pull/133194) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=875df370be806c837f58abb638329905e969ace4&end=bcfea1f8d253fd43eab36832fa601d192ac603d5&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | - | - | 0 | +| Regressions (secondary) | - | - | 0 | +| Improvements (primary) | -1.1% | [-1.1%, -1.1%] | 2 | +| Improvements (secondary) | -0.4% | [-0.7%, -0.4%] | 8 | +| All (primary) | -1.1% | [-1.1%, -1.1%] | 2 | + + +#### Mixed + +Rollup of 5 pull requests [#133234](https://github.com/rust-lang/rust/pull/133234) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=70e814bd9e532a302763f870c665c5af59c2b632&end=fda68927475070696fcc9d1f5c9c990f0e1af87a&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 2.2% | [0.2%, 5.5%] | 8 | +| Regressions (secondary) | 0.8% | [0.8%, 0.8%] | 1 | +| Improvements (primary) | - | - | 0 | +| Improvements (secondary) | -5.9% | [-5.9%, -5.9%] | 1 | +| All (primary) | 2.2% | [0.2%, 5.5%] | 8 | + +- The regression was caused by [#132732](https://github.com/rust-lang/rust/pull/132732). +- Asked the PR author if there is a way to reduce the compilation performance cost. +- Not marking as triaged. + +Reduce false positives of tail-expr-drop-order from consumed values (attempt #2) [#131326](https://github.com/rust-lang/rust/pull/131326) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a1f299953656f95004c69b24ad8071d6899fa9da&end=3fee0f12e4f595948f8f54f57c8b7a7a58127124&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 0.2% | [0.2%, 0.2%] | 1 | +| Regressions (secondary) | 0.5% | [0.2%, 2.3%] | 15 | +| Improvements (primary) | -0.7% | [-2.2%, -0.2%] | 19 | +| Improvements (secondary) | -0.6% | [-1.0%, -0.3%] | 8 | +| All (primary) | -0.7% | [-2.2%, 0.2%] | 20 | + +- This was a win on primary benchmarks. +- Marked as triaged. + +#124141 preliminaries [#132629](https://github.com/rust-lang/rust/pull/132629) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0b1bf71a71c2a1d34c212285362530ec2c4e4775&end=717f5df2c308dfb4b7b8e6c002c11fe8269c4011&stat=instructions:u) + +| (instructions:u) | mean | range | count | +|:------------------------:|:-----:|:--------------:|:-----:| +| Regressions (primary) | 0.2% | [0.1%, 0.3%] | 29 | +| Regressions (secondary) | 0.3% | [0.2%, 0.4%] | 16 | +| Improvements (primary) | - | - | 0 | +| Improvements (secondary) | -0.4% | [-0.5%, -0.3%] | 5 | +| All (primary) | 0.2% | [0.1%, 0.3%] | 29 | + +- The regressions are caused by changes in the parser that are required for further cleanup and +refactoring work. +- The regressions are genuine, but tiny. The author has deemed them to be unavoidable. +- Already marked as triaged by @nnethercote. + +## Nominated Issues + +[T-compiler](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AI-compiler-nominated) +- "Lint on combining `#[no_mangle]` and `#[export_name]`" [rust#131558](https://github.com/rust-lang/rust/pull/131558) + - Was nominated for a vibe check from T-compiler ([link](https://github.com/rust-lang/rust/pull/131558#issuecomment-2413788471)) but since then it made into final-comment-period so here we're fine +- "Lock Major Change Proposal issue" [triagebot#1858](https://github.com/rust-lang/triagebot/pull/1858) + - proposal by @**Urgau**, [Zulip thread](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Lock.20discussions.20on.20MCPs), authored [the triagebot patch](https://github.com/rust-lang/triagebot/pull/1858) + - Automatically lock Major Change Proposal issues to comments + - Goal is to enforce discussions on Zulip + - Team members with write access (and bots) can still comment + +### Oldest PRs waiting for review + +[T-compiler](https://github.com/rust-lang/rust/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-asc+label%3AS-waiting-on-review+draft%3Afalse+label%3AT-compiler) +- "add error message for c# style named arguments" [rust#118733](https://github.com/rust-lang/rust/pull/118733) (last review activity: 11 months ago) + - cc: @**Esteban Küber** +- "link libunwind dynamically and allow controlling it via `crt-static` on gnullvm targets" [rust#122003](https://github.com/rust-lang/rust/pull/122003) (last review activity: 8 months ago) + - cc: @**Vadim Petrochenkov** +- "Require `type_map::stub` callers to supply file information" [rust#104342](https://github.com/rust-lang/rust/pull/104342) (last review activity: 8 months ago) + - cc @**Sparrow Li** +- "Silence errors in expressions caused by bare traits in paths in 2021 edition" [rust#125784](https://github.com/rust-lang/rust/pull/125784) (last review activity: 5 months ago) + - cc: @**Esteban Küber** for a rebase then cc: @_**León Orell Liehr (fmease)** +- "Support target-spec json file extension in various cases" [rust#127389](https://github.com/rust-lang/rust/pull/127389) (last review activity: 4 months ago) + - cc: @**Wesley Wiser** last time ([comments](https://rust-lang.zulipchat.com/#narrow/channel/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202024-10-31/near/479897101)) we mentioned to maybe open an MCP and run a vibe check + - do we perhaps want to ask the author to draft such a proposal? + +Next meetings' agenda draft: [hackmd link](https://hackmd.io/y41E-EkQQW2kpkhEy5vTbA)