Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you be open to adding other tools to the image? #223

Open
jaskij opened this issue Dec 6, 2024 · 1 comment
Open

Would you be open to adding other tools to the image? #223

jaskij opened this issue Dec 6, 2024 · 1 comment

Comments

@jaskij
Copy link

jaskij commented Dec 6, 2024

Personally, I believe that running cargo install as part of a pipeline is an antipattern - it makes the jobs much longer, for little to no benefit.

That's why I maintain my own image on top of rust which I update as needed.

It would be amazing if popular and powerful crates were added to upstream images. At the moment, I can name three that I would like to see included:

This would be a huge step, and I can see some downsides to this:

  • need for regular builds and publishing of at least latest stable version, to keep tools updated (seems to be implemented for nightly?)
  • increased burden on maintainers in filtering feature requests what to include and what not to include
  • one time: need to set policy on which tools are fine, and which are not

I'm posting this as a general proposal, because from what I can see, the current images only really install the base toolchain and nothing more.


Regarding the policy: one thing I'd explicitly deny is duplicates of existing functionality. So, if cargo-deny makes it, cargo-audit would not get added later on because it adds nothing new. Similarly, sccache (#143) doesn't seem to make sense - most CI runners have their own caching and I'm not sure what it would add on top of that. But the specifics are for later, when you decide if you even want to open up to extra tools.

@jac18281828
Copy link

Vendor provided tooling should be as trimmed down as possible. Downstream packages and ecosystems tailored to more advanced functionality or code development can offer additional packages to suit their communities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants