Skip to content

Commit

Permalink
Do not merge: check if sometimes we can't get snippets
Browse files Browse the repository at this point in the history
  • Loading branch information
samueltardieu committed Jan 4, 2025
1 parent 38458c4 commit 182d959
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion clippy_utils/src/source.rs
Original file line number Diff line number Diff line change
Expand Up @@ -514,8 +514,13 @@ fn snippet_with_applicability_sess<'a>(
}

/// Converts a span to a code snippet. Returns `None` if not available.
#[allow(clippy::unnecessary_wraps)]
pub fn snippet_opt(sess: &impl HasSession, span: Span) -> Option<String> {
sess.sess().source_map().span_to_snippet(span).ok()
// Experiment: fail loudly if the snippet could not be obtained
match sess.sess().source_map().span_to_snippet(span) {
Ok(v) => Some(v),
Err(e) => panic!("Error when getting snippet for {span:?}: {e:?}"),
}
}

/// Converts a span (from a block) to a code snippet if available, otherwise use default.
Expand Down

0 comments on commit 182d959

Please sign in to comment.