Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ui_test to 0.21.2 #11645

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Update ui_test to 0.21.2 #11645

merged 1 commit into from
Oct 9, 2023

Conversation

Alexendoo
Copy link
Member

Hopefully fixes #11489

r? @flip1995

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 8, 2023
@Alexendoo Alexendoo mentioned this pull request Oct 8, 2023
Closed
flip1995
flip1995 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The canonicalize had problems when syncing this to rustc before. I'll do a quick dummy sync to test this before r+ing

@flip1995
Copy link
Member

flip1995 commented Oct 9, 2023

Works also in rustc. Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Oct 9, 2023

📌 Commit 850f2f5 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 9, 2023

⌛ Testing commit 850f2f5 with merge 929a288...

@bors
Copy link
Contributor

bors commented Oct 9, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 929a288 to master...

@bors bors merged commit 929a288 into rust-lang:master Oct 9, 2023
4 checks passed
@Alexendoo Alexendoo deleted the ui_test branch October 9, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows weirdness with GitHub runners and temporary directories
4 participants
@Alexendoo @flip1995 @bors @rustbot