Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multiple pushes in vec_init_then_push example #11701

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

Alexendoo
Copy link
Member

Makes the perf argument clearer, since a single push doesn't have unnecessary allocations compared to vec![x]

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2023

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 23, 2023
@Jarcho
Copy link
Contributor

Jarcho commented Oct 30, 2023

Thank you. @bors r+

@bors
Copy link
Contributor

bors commented Oct 30, 2023

📌 Commit e1b287c has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 30, 2023

⌛ Testing commit e1b287c with merge cdc4d56...

@bors
Copy link
Contributor

bors commented Oct 30, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing cdc4d56 to master...

@bors bors merged commit cdc4d56 into rust-lang:master Oct 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants