Add "OpenTelemetry" to default doc_valid_idents
#11926
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Alexendoo (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
|
I don't suppose someone has a moment to review this? :-) |
|
☔ The latest upstream changes (presumably #12018) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@edmorley I'll review it since it seems like Alex is busy (and I kinda caused the merge conflict 😬) |
The OpenTelemetry project's name is all one word (see https://opentelemetry.io), so currently triggers a false positive in the `doc_markdown` lint. The project is increasing rapidly in popularity, so it seems like a worthy contender for inclusion in the default `doc_valid_idents` configuration. I've also moved the existing "OpenDNS" entry earlier in the list, to restore the alphabetical ordering of that "Open*" row. The docs changes were generated using `cargo collect-metadata`. changelog: [`doc_markdown`]: Add `OpenTelemetry` to the default configuration as an allowed identifier
edmorley
force-pushed
the
update-default-doc_valid_idents
branch
from
0a10da8 to
a16a850
Compare
|
@blyxyas Thank you. I've rebased on |
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
The OpenTelemetry project's name is all one word (see https://opentelemetry.io), so currently triggers a false positive in the
doc_markdownlint.The project is increasing rapidly in popularity, so it seems like a worthy contender for inclusion in the default
doc_valid_identsconfiguration.I've also moved the existing "OpenDNS" entry earlier in the list, to restore the alphabetical ordering of that "Open*" row.
The docs changes were generated using
cargo collect-metadata.changelog: [
doc_markdown]: AddOpenTelemetryto the default configuration as an allowed identifier