Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include GitLab in the CI section of the clippy doc book #12025

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Include GitLab in the CI section of the clippy doc book #12025

merged 1 commit into from
Jan 4, 2024

Conversation

jetlime
Copy link
Contributor

@jetlime jetlime commented Dec 27, 2023

Fixes #12012
changelog: Docs: [Continuous Integration] now includes how to use clippy in GitLab CI.

@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 27, 2023
@jetlime
Copy link
Contributor Author

jetlime commented Dec 27, 2023

Sorry for the double PR, I deleted the entire git history of my previous fork by mistake, which messed up my commit :)

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

book/src/continuous_integration/gitlab.md Outdated Show resolved Hide resolved
@flip1995
Copy link
Member

flip1995 commented Jan 4, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jan 4, 2024

📌 Commit 89e4b71 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 4, 2024

⌛ Testing commit 89e4b71 with merge 0bf0b88...

@bors
Copy link
Contributor

bors commented Jan 4, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 0bf0b88 to master...

@bors bors merged commit 0bf0b88 into rust-lang:master Jan 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitlab CI in Clippy Documentation
4 participants