stop linting [blocks_in_conditions] on match with weird attr macro case
#12040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
J-ZhengLi
force-pushed
the
issue12016
branch
from
d933dab to
48e2372
Compare
|
☔ The latest upstream changes (presumably #12167) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Someone help me look at this plz? @rustbot r? @rust-lang/clippy |
y21
reviewed
Feb 9, 2024
J-ZhengLi
force-pushed
the
issue12016
branch
from
48e2372 to
85f98e0
Compare
J-ZhengLi
force-pushed
the
issue12016
branch
from
85f98e0 to
4cc7b7e
Compare
y21
approved these changes
Feb 11, 2024
|
Thank you! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fixes: #12016
changelog: [
blocks_in_conditions] - fix FP onmatchwith weird attr macroThis might not be the best solution, as the root cause (i think?) is the
spanof block was incorrectly given by the compiler?I'm open to better solutions