Remove mitigations for incorrect node args #12041
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change https://github.com/rust-lang/rust/pull/118420/files#r1419874371 adds a missing
write_args
to properly record node args for lang-item calls.Thus, in the
unnecessary_to_owned
lint, this ensures that thecall_generic_args
extracted byget_callee_generic_args_and_args
are always correct, and we can remove the mitigation for #9504 and #10021 since the root cause has been fixed.I'm not sure if there is other now-unnecessary code that can be removed, but this is the one I found when investigating #11965 (comment).
changelog: none