Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New lint map_all_any_identity #13499

Merged
merged 2 commits into from
Oct 29, 2024
Merged

New lint map_all_any_identity #13499

merged 2 commits into from
Oct 29, 2024

Conversation

samueltardieu
Copy link
Contributor

This lint has been inspired by code encountered in Clippy itself (see the first commit).

changelog: [map_all_any_identity]: new lint

@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2024

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 4, 2024
@samueltardieu
Copy link
Contributor Author

r? @xFrednet

@rustbot rustbot assigned xFrednet and unassigned y21 Oct 12, 2024
xFrednet
xFrednet reviewed Oct 13, 2024
View reviewed changes
Copy link
Member

@xFrednet xFrednet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three tiny nits, which should be easy to fix. Then it'll be ready :D

I've created an FCP: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/FCP/near/476583638

clippy_lints/src/methods/mod.rs Outdated Show resolved Hide resolved
clippy_lints/src/methods/map_all_any_identity.rs Outdated Show resolved Hide resolved
clippy_lints/src/methods/mod.rs Outdated Show resolved Hide resolved
@xFrednet xFrednet added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) S-final-comment-period Status: final comment period it will be merged unless new objections are raised (~1 week) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 13, 2024
@samueltardieu
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Oct 16, 2024
@bors
Copy link
Contributor

bors commented Oct 29, 2024

☔ The latest upstream changes (presumably #13437) made this pull request unmergeable. Please resolve the merge conflicts.

@xFrednet xFrednet added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties S-final-comment-period Status: final comment period it will be merged unless new objections are raised (~1 week) labels Oct 29, 2024
@xFrednet
Copy link
Member

This version looks good to me, and the FCP should also be over.

Thank you for the implementation!

Roses are red,
This looks fine,
Rebase is pending,
Then it's r=me time

@bors
Copy link
Contributor

bors commented Oct 29, 2024

✌️ @samueltardieu, you can now approve this pull request!

If @xFrednet told you to "r=me" after making some further change, please make that change, then do @bors r=@xFrednet

@samueltardieu
Copy link
Contributor Author

@bors r=@xFrednet

@bors
Copy link
Contributor

bors commented Oct 29, 2024

📌 Commit 91a1d16 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 29, 2024

⌛ Testing commit 91a1d16 with merge 35a7095...

@bors
Copy link
Contributor

bors commented Oct 29, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 35a7095 to master...

@bors bors merged commit 35a7095 into rust-lang:master Oct 29, 2024
11 checks passed
@samueltardieu samueltardieu deleted the map-all-any-identity branch November 3, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xFrednet xFrednet xFrednet approved these changes

Assignees

@xFrednet xFrednet

Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samueltardieu @rustbot @bors @xFrednet @y21