Fix not working lint anchor (generation and filtering) #13588
Conversation
rustbot
added
the
S-waiting-on-review
|
Considering the second bug (invalid lint ID filtering) was a one line change, I also added it here as well. |
GuillaumeGomez
changed the title
|
Thanks for fixing this. However when clicking on the the link symbol, I kind of expect for the lint panel to open. Just jumping there is a bit confusing, as I lose track where it jumps to. The lint is then on the top of the page, but there's no visual indication where it was moved/scrolled to. The behavior now feels like "oh, where did it just jump to? Ah, to the lint I clicked on at the top of the page". When clicking on the generated link, the lint panel opens. |
|
When JS is disabled, not much we can do for that. However, when JS is enabled, it's now adding the anchor in the URL and opening the lint as you asked (in the last commit). |
|
Thanks! Now the only thing that is still broken is the indentation in code blocks: But that can be addressed in another PR @bors r+ |
|
Didn't have time to look at it yet. Planning to do it next. Hopefully tomorrow. |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
As spotted by @flip1995, the anchor button is currently not working. Problem was the JS that was preventing the web browser from adding the hash at the end of the URL.
For the second bug fixed, the JS was stripping two characters instead of just stripping the
#at the beginning.changelog: Fix clippy page lint anchor (generation and filtering)
r? @flip1995