Fix allow_attributes when expanded from some macros #13599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
blyxyas
reviewed
Oct 24, 2024
RuairidhWilliamson
force-pushed
the
proc_macro_attr
branch
2 times, most recently
from
2fa4dc3 to
4a81320
Compare
RuairidhWilliamson
force-pushed
the
proc_macro_attr
branch
from
4a81320 to
59ecf4d
Compare
|
I've created a macro that recreates what bytemuck was doing and added it to the tests. On the bright side, given how much effort it takes to create a macro that generates tokens where the spans start with |
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13349
The issue here was that the start pattern being matched on the original source code was not specific enough. When using derive macros or in the issue case a
#[repr(C)]the#would match the start pattern meaning that the expanded macro appeared to be unchanged and clippy would lint it.The change I made was to make the matching more specific by matching
#[identat the start. We still need the second string to match just the ident on its own because of things like#[cfg_attr(panic = "unwind", allow(unused))].I also noticed some typos with start and end, these code paths weren't being reached so this doesn't fix anything.
changelog: FP: [
allow_attributes]: don't trigger when expanded from some macros