Fix type suggestion for manual_is_ascii_check #13916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Alexendoo (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
Alexendoo
reviewed
Jan 7, 2025
Comment on lines
133
to
134
| let ty_str = arg_type.to_string(); | ||
| return Some((*ty_span, ty_str)); |
There was a problem hiding this comment.
Thanks!
Just one nit, we can return the Ty here to avoid allocating the extra string since it implements Display
There was a problem hiding this comment.
Thanks for the hint, I've updated this part now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13913 .
changelog: [
manual_is_ascii_check]: fix type suggestions for referencesPreviously it only derived
charandu8types, now it should always annotate the lambda parameter with the correct type (e.g.&char).I'm quite new to Rust and this is my first contact with clippy, so I'm open for suggetions :)