Do not merge: check if we sometimes fail to get snippets #13941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
push-zlrztsxvwkmx
branch
from
0e8033c to
28c06ee
Compare
samueltardieu
force-pushed
the
push-zlrztsxvwkmx
branch
2 times, most recently
from
4b9a44e to
478a59c
Compare
samueltardieu
force-pushed
the
push-zlrztsxvwkmx
branch
3 times, most recently
from
182d959 to
421485d
Compare
|
maybe this could be a debug assertion like the infamous https://github.com/rust-lang/rust/blob/243d2ca4db6f96d2d18aaf3a2381251d38eb6b0b/compiler/rustc_errors/src/diagnostic.rs#L1007 |
|
Indeed. Another thing I realized when exchanging with @GuillaumeGomez is that we appear to use |
|
Sounds like a case where we should return |
Yes, but we return |
|
Adding a |
The code should not attempt to obtain a snippet by capping the function signature span with its identifier span without checking that they are in the same context.
samueltardieu
force-pushed
the
push-zlrztsxvwkmx
branch
from
421485d to
ce1f1b1
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
The code should not attempt to obtain a snippet by capping the function signature span with its identifier span without checking that they are in the same context. This is the only instance I could identify where placeholders were used instead of the real snippet when running the CI lintcheck. Moreover, the placeholders were not even used, as they snippet was obtained prematurely. Found in the context of #13941 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am looking at snippets and placeholders, and was wondering in which case a snippet could fail. This is to run a
lintcheckin CI conditions. Not obtaining a snippet will result into an ICE.changelog: none