Fix RISC-V Packed SIMD intrinsics compilation #1674
+136
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/rust#129593.
Currently the P extension is still unratified, so there is no support for it in the upstream LLVM for now, and thus no LLVM built-in functions or serialization of instructions are provided.
This PR implements quick fixes to some of the instructions to fix them causing compilation failures (see issue rust-lang/rust#129593). Calling it a "quick fix" because ideally we could replace all
.insn
with LLVM built-in functions in the future when LLVM supports the P extension.This PR also adds
assert_instr(unknown)
to each function so that we can at least make sure they compile. Since there is no serialization yet, the stdout ofassert_instr
is likeSo I left "unknown" here, also with the idea that if LLVM upstream provides support for the P extension at some point in the future, we can know in time and then update our implementation.
r? @workingjubilee
CC @Amanieu