Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stdarch support for wasm32-wali-linux-musl Tier-3 Linux target #1702

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arjunr2
Copy link

@arjunr2 arjunr2 commented Jan 17, 2025

To support the new Tier-3 target wasm32-wali-linux-musl within the rust compiler : rust-lang/rust#135651

Minimally, this just disables dynamic-linking related Linux features which is not supported yet in Wasm.

@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) some time within the next two weeks.

@sayantn
Copy link
Contributor

sayantn commented Jan 18, 2025

Please rebase

@bjorn3
Copy link
Member

bjorn3 commented Jan 18, 2025

Is there a reason wali doesn't provide getauxvval?

@arjunr2
Copy link
Author

arjunr2 commented Jan 18, 2025

Is there a reason wali doesn't provide getauxvval?

Wasm doesn't have a dynamic linking specification yet. These features can be added back in the future once supported

@bjorn3
Copy link
Member

bjorn3 commented Jan 18, 2025

Directly linking to getauxval rather than using dlsym should work if libc for wali is guaranteed to support it, right? The only reason std_detect is using dlsym is because older libc versions for some targets don't support getauxval.

@arjunr2
Copy link
Author

arjunr2 commented Jan 18, 2025

That's true, we could probably just disable std_detect_dlsym_getauxval when building stdarch for rustc. That should work right?

WALI libc does expose getauxval but support for it is not fully specified/handled yet (particularly architecture-specific types/values) As such, preventing it from being called for the time being is preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants