Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rocket with stable and maintained web framework #1783

Closed
senekor opened this issue Mar 21, 2023 · 5 comments
Closed

Replace rocket with stable and maintained web framework #1783

senekor opened this issue Mar 21, 2023 · 5 comments
Labels
A-Content The written content on the website. C-Bug Something isn't working.

Comments

@senekor
Copy link
Contributor

senekor commented Mar 21, 2023

What needs to be fixed?

The web server example should use a different framework. Rocket has been in a questionable maintenance status for years. Its latest stable release requires nightly. Newcomers may get a bad impression of the state of Rust's ecosystem, if the "officially" recommended web framework is poorly maintained and requires an unstable toolchain.

Judging from download numbers on crates.io and (subjectively perceived) "internet buzz", axum and actix-web are generally favored by the community these days. Both are stable and actively maintained.

Page(s) Affected

https://www.rust-lang.org/what/networking

Suggested Improvement

The code snippet using rocket should be replaced by one using axum or actix-web.

I will be happy to contribute this change if the maintainers agree with it.

@senekor senekor added A-Content The written content on the website. C-Bug Something isn't working. labels Mar 21, 2023
@senekor
Copy link
Contributor Author

senekor commented Mar 21, 2023

@Manishearth apologies for hijacking my own thread here, but could you use help maintaining this site? I read about the maintenance state on this PR. I understand if the only thing to do for now is to wait for the new governance model. But if there is an opportunity to help out, I would be glad to do so.

@Manishearth
Copy link
Member

I think help for non-content changes is highly appreciated. This is a content change and I'd rather not have us do that just yet. I'll keep it in mind that you're interested in helping out here.

In general as the official website we have to be careful about picking examples. Annoyingly, the domain WG that was working on networking stuff is no longer active so we can't delegate this particular thing to them.

@senekor
Copy link
Contributor Author

senekor commented Mar 21, 2023

I understand completely. What can I help with? Should I go through the issues, pick non-content related ones and work on any of those?

@Manishearth
Copy link
Member

I don't know if there's much to do right now. Feel free to go through the issues though.

@senekor
Copy link
Contributor Author

senekor commented Nov 18, 2023

Rocket now has a stable release which doesn't require nightly and an organisation is being built to ensure reliable maintenance into the future. 🥳

With these changes, I don't see any pressing reason to change the example anymore.

@senekor senekor closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Content The written content on the website. C-Bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

2 participants