Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List support for Visual Studio 2022 on https://www.rust-lang.org/tools #1781 #1782

Closed
wants to merge 1 commit into from

Conversation

parthopdas
Copy link

Adding buttons for VS in https://www.rust-lang.org/tools

@parthopdas parthopdas requested a review from a team as a code owner March 20, 2023 20:09
@Manishearth
Copy link
Member

Manishearth commented Mar 20, 2023

There are lots of editors with Rust support, we don't want to list all of them (and I'm reluctant to merge this since this adds a new row to the table).

The website has been in a bit of a limbo for a while since there's no official direction for it; there was originally intention for different teams to have decisionmaking power over different parts of the website but that's not currently the case. As such, we rarely if ever change website content.

Once the new Rust governance model gets set up I'm hoping to work with the new council to clarify who has direction on which parts of the website, and then maybe such PRs can merge. For now, this PR can stay open if you'd like but I'm not planning on merging it.

image

@parthopdas
Copy link
Author

okay. not worth the battle.

there are some misgivings however.

  • VS is not "just another editor" - it is "the" editor for windows, vscode has subpar editor / refactoring / testing / debugging experience in comparison
  • before the last 3 editors were added there was an incomplete columns - so what if there is a partial row
  • if the site is in a limbo and the editor is one of the major ones and the change is simple, not sure what the big deal is to push this through.

@Manishearth
Copy link
Member

Yes, I understand that it is the editor for Windows. Personally I'd like to remove some of the editors on that list (Geany isn't nearly as popular as it was in the past) and replace them. I haven't done so because of the policy we've been running this on.

if the site is in a limbo and the editor is one of the major ones and the change is simple, not sure what the big deal is to push this through.

As long as it's in this state the most straightforward rule to follow has been to only merge fixes to things. The moment we start merging more we start having to justify things and deal with people who are annoyed that their change wasn't merged but a different change was. It's a clear line in the sand. Like sure, you can make the argument that it is a major editor to me (and I agree with it), but if I merge this I have to make that same argument to other people who want their editor on the list. I have only committed to keeping the website working, not to maintaining the content; I do not have the time nor the inclination to manage that kind of maintenence.

It's a bad situation but the website has been in a bad situation for a while, and some other things need to be fixed first. The website is something which a lot of people have strong opinions about but few want to spend time dealing with that, which is why it's come to the state it's in now.

@Manishearth
Copy link
Member

Actually, you know what? Atom is deprecated and has been for a year.

Go ahead and replace the Atom entry with Visual Studio; and if people argue about it I can point them to this thread.

But for future reference: content changes to the website have no guarantee of being even considered.

@dtolnay
Copy link
Member

dtolnay commented Jan 14, 2024

Go ahead and replace the Atom entry with Visual Studio; and if people argue about it I can point them to this thread.

Atom has been deleted as of #1913. I opened #1915 to delete Geany as well, and add Visual Studio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants