Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unknown platform issue template #2041

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Sep 9, 2024

Apparently, the previous instructions to include the values for navigator.platform and navigator.appVersion were not clear enough. This automates the process completely, hopefully preventing useless issues like these:

Security wise, I think encodeURIComponent should prevent any risk of code injection via navigator.platform (I don't know if that's even possible in the first place).

@senekor senekor requested a review from a team as a code owner September 9, 2024 20:43
@Manishearth
Copy link
Member

Good idea!

@Manishearth Manishearth merged commit 315ae60 into master Sep 9, 2024
2 checks passed
@Manishearth Manishearth deleted the remo/xqqkzxwpwtml branch September 9, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants