image_reader: Add AImageReader_newWithDataSpace() from api-level-34
#474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
imagereader-dataspace
branch
from
6aa2005
to
1b19d6c
Compare
MarijnS95
force-pushed
the
imagereader-dataspace
branch
4 times, most recently
from
1b6b867
to
79cc7d1
Compare
Android 14 (U, API level 34) adds `DataSpace` support to `ImageReader` with a new constructor and a getter, and finally switches to the regular `HardwareBufferFormat` instead of the restricted `ImageFormat` enum to select the underlying buffer format. After all, an `AImage` can be turned into a `HardwareBuffer` which supports a wider range of formats. Also clean up and commonize some panics on pedantic `.try_from()` checks.
MarijnS95
force-pushed
the
imagereader-dataspace
branch
from
79cc7d1
to
bbf1a49
Compare
MarijnS95
changed the title
AImageReader_newWithDataSpace()AImageReader_newWithDataSpace() from api-level-34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android 14 (U, API level 34) adds
DataSpacesupport toImageReaderwith a new constructor and a getter, and finally switches to the regularHardwareBufferFormatinstead of the restrictedImageFormatenum to select the underlying buffer format. After all, anAImagecan be turned into aHardwareBufferwhich supports a wider range of formats.