CI: Drop unneeded cargo-ndk tool from build-test
#476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent borked `cargo-ndk` release [^1] [^2] lead me to investigate why we are using a nonstandard tool in our CI in the first place. Compiling / build-testing the `ndk` crate does not require any external tooling whatsoever nor an SDK setup: this crate is a pure wrapper over pre-generated C bindings in the `ndk-sys` crate, which only require NDK _libraries_ (and an Android-capable linker) when linking actual runnable binaries (typically shared libraries or executables). And the Rust compiler natively supports compiling Rust code for Android targets. [^1]: https://github.com/rust-mobile/ndk/actions/runs/9149848316 [^2]: https://togithub.com/bbqsrc/cargo-ndk/pull/135#discussion_r1606097922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent borked
cargo-ndkrelease 1 2 lead me to investigate why we are using a nonstandard tool in our CI in the first place. Compiling / build-testing thendkcrate does not require any external tooling whatsoever nor an SDK setup: this crate is a pure wrapper over pre-generated C bindings in thendk-syscrate, which only require NDK libraries (and an Android-capable linker) when linking actual runnable binaries (typically shared libraries or executables). And the Rust compiler natively supports compiling Rust code for Android targets.Footnotes
https://github.com/rust-mobile/ndk/actions/runs/9149848316 ↩
https://togithub.com/bbqsrc/cargo-ndk/pull/135#discussion_r1606097922 ↩